You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/25 13:24:52 UTC

[GitHub] [apisix] bisakhmondal commented on a change in pull request #6199: fix(proto): avoid sharing state

bisakhmondal commented on a change in pull request #6199:
URL: https://github.com/apache/apisix/pull/6199#discussion_r791704631



##########
File path: apisix/plugins/grpc-transcode/proto.lua
##########
@@ -29,6 +30,10 @@ local lrucache_proto = core.lrucache.new({
 local proto_fake_file = "filename for loaded"
 
 local function compile_proto(content)
+    -- clear pb state
+    pb.state(nil)

Review comment:
       Isn't it redundant? I think Line 54 is already retrieving the current pb state and setting it to nil.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org