You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Tim Ruppert (JIRA)" <ji...@apache.org> on 2006/11/30 09:01:21 UTC

[jira] Created: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Anonymous Checkout Refactoring [ ecommerce ] Part #2
----------------------------------------------------

                 Key: OFBIZ-510
                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
    Affects Versions: SVN trunk
            Reporter: Tim Ruppert


So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.

Currently we have a long process that contains these functions / screens:

1. Personal Info
2. Shipping Address
3. Shipping Options
4. Payment Options
5. Payment Information (and Billing Address)
6. Review Order
7. Order Confirmation

We are going to shorten it up this way:

1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
2. Shippint Options 
3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
4. Review & Place Order - enter the credit card right here - put error handling here as well
5. Order Confirmation

This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459118 ] 
            
Jacopo Cappellato commented on OFBIZ-510:
-----------------------------------------

Chris, I think you have fully expressed your concerns now, the person that will review (and possibly commit) this patch will read all these comments and get your point of view: so there is no reason to continue to waste your and others time in this diatribe.

Anil, Tim I think that the work you did so far is self explanatory (really thanks for your contribution) and there is no need, in my opinion, to continue this discussion with Chris: in the OFBiz project, such as in every other community, there are people who acts and people who speaks...

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458506 ] 
            
Jacques Le Roux commented on OFBIZ-510:
---------------------------------------

Sorry Tim,

In my 06:59AM comment above I was meaning "Thanks Tim" (of course ;o)

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459105 ] 
            
Chris Howe commented on OFBIZ-510:
----------------------------------

It makes it a lot easier to review issues/patches if the patches are submitted to the issue that they belong.  If an issue is blocking the progress of another issue bring it to the committers attention.  I'm looking at  CustomerEvents.xml and custsettings.ftl now because they seem to be OFBIZ-512.  If I can figure it out, I'll post my reply there.

My point on the async call is that you're not gaining anything for this case over an approach that loads the data the first time around.  You're simply complicating the issue in order to use a buzzword.  If and when you do come across a scenario that would benefit from the async call, I think it would be more efficient to use the approach in OFBIZ-411 in whether or not to make dojo.js available to a page.

If you're itching to use dojo for the checkout screens, I would think the wizzard widget would be a much cleaner and user friendly route to take.

Do you think it would be possible for you to outline what actual issue each file that is changed is in regards to?  This would make it a lot faster to get through.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-510?page=all ]

Tim Ruppert updated OFBIZ-510:
------------------------------

    Attachment: 3stepAnonCheckoutWithAjax.patch

This is MUCH shorter anonymous checkout process that should really make everyone happy out there who's been laboring thru it all this time.  The review page with the integrated Credit Card portion is done in AJAX with the Dojo toolkit on the front end and JSON on the backend.

Thanks to Anil & Ashish for their part in helping this process along.


> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459127 ] 
            
Jacopo Cappellato commented on OFBIZ-510:
-----------------------------------------

I know, from private mail I've received, that my previous comment could have offended someone.
It was really not my intention to offend Chris (or others) and I'm sorry if this is happened.


> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12454553 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

Preview of Phase #3:

Keep in mind that all of these steps are after the shopping cart and quantity change page.  Ultimately I'd like it to look like this - including the Shopping Cart portion:

1. Shopping Cart & Calculate Shipping
2. Customer Details (Personal Information / Shipping Address / Billing Address)
3. Review & Place Order (assuming credit card only for this example) - enter the credit card right here - put error handling here as well
4. Order Confirmation

My final goal after phase three would be to see a checkout process that resembled what I did for one of my customers back in the day - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
Hey, Chris - let's just leave this at this (and please let's not  
dissect this email as well).

We're about to submit a patch that allows both the old system (6 step  
process) and the new system (3 step process with a Dojo-based payment  
process) working, so that people have options.  It was NEVER our  
intention to break anyone's code, just give them a system that would  
be able to fix the age-old problem of people being too scared to  
effectively customize the shopping cart process.  Now they'll have  
two refactored processes to start with - and they can feel empowered.

If you have another option to put forth, that doesn't use Ajax that  
can work nicely, please submit this as another anonymous checkout  
process patch.  I personally would love to see it and have something  
like this in our repertoire as we go forward.

Let's keep the smack talking to a minimum and do the best that we can  
to be tactful in supplying feedback for people.  There are a lot of  
different personalities as well as cultures that are present in this  
project, and at times some people cross lines, often without knowing  
it.  Please just take a little extra time, especially once someone  
has called you out for it more than once, to ensure that your point  
is articulated in as respectful a manner as possible.

I'm sure that everyone can feel me when I say that one of the great  
things about this community, as opposed to many of the other open  
source projects I've been apart of, is the lack of dialogues that go  
this way.  Let's do our best to keep it that way.

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6594


On Dec 17, 2006, at 10:57 AM, Chris Howe wrote:

>
> --- "David E. Jones (JIRA)" <ji...@apache.org> wrote:
>
>>     [
>>
> http://issues.apache.org/jira/browse/OFBIZ-510? 
> page=comments#action_12459141
>> ]
>>
>> David E. Jones commented on OFBIZ-510:
>> --------------------------------------
>>
>> Jacopo: I don't think you have anything to apologize
>> for in that comment. In my opinion it was right on.
>> The comments on this issue have strayed far away
>> from the main point.
>
> I would have to strongly disagree.  The only comments
> that stray from a discussion about how to refactor the
> anonymous checkout are yours (David) and Jocopo's.
>
>> The comments and feedback from
>> Chris should certainly be considered as we move
>> forward with this, but his language is clearly too
>> strong. In other words, while his opinion is
>> respected, that's all it is. As you say Jacopo, it
>> is the committers responsibility to review and deal
>> with this as it has always been and Chris, in my
>> opinion, definitely crossed the line in terms of
>> representing the influence he has on this issue.
>>
>
> This is typical, David.  One day you speculate that an
> effort will fail because the community  has seemed to
> lack the resources to carry on similar endeavors in
> the past and the next day you minimalize the efforts
> that you complained were lacking.
>
>> In other words, I'm totally for reading and
>> respecting what Chris Howe has to say, but if he
>> does so in an inflammatory or confrontational way,
>> we don't have to and generally shouldn't respond.
>
> Please consult a dictionary.  The only diatribe,
> inflammatory or confrontational comments have come
> from you (David) and Jocopo as they have been the only
> ad hominem arguments.
>
>> Chris definitely needs to research more of what is
>> going on in OFBiz and participate with more of a
>> spirit of contribution and cooperation. This isn't
>> the first time it has come up, and probably won't be
>> the last.
>>
>> For anyone who hasn't read it yet, search for
>> "apache troll" on google and you'll get some helpful
>> information on the apache.org site about this.
>>
>> Chris: this message may be about you, but my
>> intention is not to direct it to you. I know in
>> advance you'll be offended by this because you have
>> in the distant and recent past, and you may respond
>> however you wish, I really have no intention of
>> answering any criticism from you. These sorts of
>> discussions are a waste of time, effort, and
>> community good will and only serve to confuse and
>> alienate people. My intent here is to let other
>> people know that this can easily stop and there is
>> an easy way to do it. I would really appreciate it
>> if you could also make an effort to contribute in
>> this way and avoid the troll patterns, don't make
>> things so personal, and if you want to get involved
>> then do it in terms of action and constructive,
>> cooperative discussion.
>
> Have you read the pages that you advise others to
> read?    The only comments that are insulting and off
> topic with the intent to provoke a response have been
> yours.
>
> This is a portion of the off list message I sent to
> Jocopo and I feel fully describes the spirit of most
> of my contributions in code, tutorial and disucssion.
>
> Like you, I run a business that relies heavily
> on the OFBIZ project.  Unlike you, I do not have the
> privilege of changing the community code to suit my
> deployment.  You have certainly earned that privilege.
>  I respect that and am not trying to take that away
> from you.  However, please understand that when
> someone, like myself, who does not have those
> privileges comes across an inflexible part of OFBiz
> and we have to come up with a solution, we have to
> maintain that solution all by our lonesome.  So when
> someone offers a patch that will break other's
> deployments, I'm going to plead with them to find
> another solution.  The more time people in the
> community have to spend maintaining their own
> solution, the less time they have to contribute to SVN
> and reviewing patches.


Re: [jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by Chris Howe <cj...@yahoo.com>.
--- "David E. Jones (JIRA)" <ji...@apache.org> wrote:

>     [
>
http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459141
> ] 
>             
> David E. Jones commented on OFBIZ-510:
> --------------------------------------
> 
> Jacopo: I don't think you have anything to apologize
> for in that comment. In my opinion it was right on.
> The comments on this issue have strayed far away
> from the main point. 

I would have to strongly disagree.  The only comments
that stray from a discussion about how to refactor the
anonymous checkout are yours (David) and Jocopo's.

> The comments and feedback from
> Chris should certainly be considered as we move
> forward with this, but his language is clearly too
> strong. In other words, while his opinion is
> respected, that's all it is. As you say Jacopo, it
> is the committers responsibility to review and deal
> with this as it has always been and Chris, in my
> opinion, definitely crossed the line in terms of
> representing the influence he has on this issue.
> 

This is typical, David.  One day you speculate that an
effort will fail because the community  has seemed to
lack the resources to carry on similar endeavors in
the past and the next day you minimalize the efforts
that you complained were lacking. 

> In other words, I'm totally for reading and
> respecting what Chris Howe has to say, but if he
> does so in an inflammatory or confrontational way,
> we don't have to and generally shouldn't respond.

Please consult a dictionary.  The only diatribe,
inflammatory or confrontational comments have come
from you (David) and Jocopo as they have been the only
ad hominem arguments.  

> Chris definitely needs to research more of what is
> going on in OFBiz and participate with more of a
> spirit of contribution and cooperation. This isn't
> the first time it has come up, and probably won't be
> the last.
> 
> For anyone who hasn't read it yet, search for
> "apache troll" on google and you'll get some helpful
> information on the apache.org site about this.
> 
> Chris: this message may be about you, but my
> intention is not to direct it to you. I know in
> advance you'll be offended by this because you have
> in the distant and recent past, and you may respond
> however you wish, I really have no intention of
> answering any criticism from you. These sorts of
> discussions are a waste of time, effort, and
> community good will and only serve to confuse and
> alienate people. My intent here is to let other
> people know that this can easily stop and there is
> an easy way to do it. I would really appreciate it
> if you could also make an effort to contribute in
> this way and avoid the troll patterns, don't make
> things so personal, and if you want to get involved
> then do it in terms of action and constructive,
> cooperative discussion.

Have you read the pages that you advise others to
read?    The only comments that are insulting and off
topic with the intent to provoke a response have been
yours.

This is a portion of the off list message I sent to
Jocopo and I feel fully describes the spirit of most
of my contributions in code, tutorial and disucssion.

Like you, I run a business that relies heavily
on the OFBIZ project.  Unlike you, I do not have the
privilege of changing the community code to suit my
deployment.  You have certainly earned that privilege.
 I respect that and am not trying to take that away
from you.  However, please understand that when
someone, like myself, who does not have those
privileges comes across an inflexible part of OFBiz
and we have to come up with a solution, we have to
maintain that solution all by our lonesome.  So when
someone offers a patch that will break other's
deployments, I'm going to plead with them to find
another solution.  The more time people in the
community have to spend maintaining their own
solution, the less time they have to contribute to SVN
and reviewing patches. 


[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459141 ] 
            
David E. Jones commented on OFBIZ-510:
--------------------------------------

Jacopo: I don't think you have anything to apologize for in that comment. In my opinion it was right on. The comments on this issue have strayed far away from the main point. The comments and feedback from Chris should certainly be considered as we move forward with this, but his language is clearly too strong. In other words, while his opinion is respected, that's all it is. As you say Jacopo, it is the committers responsibility to review and deal with this as it has always been and Chris, in my opinion, definitely crossed the line in terms of representing the influence he has on this issue.

In other words, I'm totally for reading and respecting what Chris Howe has to say, but if he does so in an inflammatory or confrontational way, we don't have to and generally shouldn't respond. Chris definitely needs to research more of what is going on in OFBiz and participate with more of a spirit of contribution and cooperation. This isn't the first time it has come up, and probably won't be the last.

For anyone who hasn't read it yet, search for "apache troll" on google and you'll get some helpful information on the apache.org site about this.

Chris: this message may be about you, but my intention is not to direct it to you. I know in advance you'll be offended by this because you have in the distant and recent past, and you may respond however you wish, I really have no intention of answering any criticism from you. These sorts of discussions are a waste of time, effort, and community good will and only serve to confuse and alienate people. My intent here is to let other people know that this can easily stop and there is an easy way to do it. I would really appreciate it if you could also make an effort to contribute in this way and avoid the troll patterns, don't make things so personal, and if you want to get involved then do it in terms of action and constructive, cooperative discussion.


> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Daniel Kunkel (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12454666 ] 
            
Daniel Kunkel commented on OFBIZ-510:
-------------------------------------

Hi Tim

This sounds great.  A couple of ideas that may be worth considering:

1.) What do you think of supporting registered customers by comingling the login with the customer details. If the customer has an account, they can just put in username/email and a password vs having to fill in all the other data.

2.) Would it work to have a "other payment options" and or a radio list of the payment options on the Review page that would step through an optional payment page. It would seem that this would be very  simple for credit card orders, and yet support other payment methods for companies that want to use this checkout system, but need to accept other forms of payment besides credit cards.


> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-510?page=all ]

David E. Jones updated OFBIZ-510:
---------------------------------

    Attachment:     (was: Anon_Checkout_2_and_6_step_combined_simultaneous.patch)

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458334 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

It's 100% AJAX in the way it handles the multiple payment types on the Review Order Screen.  That being said, there's always the old checkout process (or even the current one with all of it's steps) for people who are concerned about the non-JavaScript using customers :)

I will check this out later this evening as well and report back.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459109 ] 
            
Chris Howe commented on OFBIZ-510:
----------------------------------

Tim,

I feel you've completely missed my point and sentiment.  

My advice was to tackle one issue at a time.  It's very difficult and time consuming for someone to review your efforts if we're chasing down how a particular change plays into it and then to find out after a half hour of chasing, that it doesn't.  

My contention on the order screens is not on whether you require different screen definitions to accomplish your goals.  The contention is that other people use screens from the ecommerce component without utilizing the entirety of the ecommerce component.  Renaming and removing of screen definitions is outside of the scope of your improvement and this manner of consolidating is not necessary to accomplish your improvement.  

As David mentioned in the ML, if this is a NEW checkout process it should be a parallel one and not a replacement one.  New functionality should not break old code unless there is a real benefit in doing so.  There are so many approaches that one can take to obtain both benefits.

I was not slamming Anil or you for your choices of implementation.  You agree, functionality that is gained by making this async call can be accomplished without it.  The async call being made is much more complicated than the JS only solution.  If that's true, then the only benefit that this patch gives is to be able to say that we use Dojo in OFBIZ.  Is there another benefit that I'm missing? I have no doubt that OFBiz will take advantage of AJAX approaches, but again, it's not needed here.

I am all for creating more ways to incorporate technology into OFBiz.  But you need to remember that this is a community project and the KISS philosophy should prevail unless there is a real reason to complicate things.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-510?page=all ]

David E. Jones updated OFBIZ-510:
---------------------------------

    Attachment:     (was: 3stepAnonCheckoutWithAjax.patch)

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-510?page=all ]

Tim Ruppert updated OFBIZ-510:
------------------------------

    Attachment: Anon_Checkout_2_and_6_step_combined_simultaneous.patch

This patch takes it down from a 3 step process to a 2 step process - while still preserving the 6 step process.  Thanks again to all that contributed to this patch.  Please review and let's get this party started.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch, Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458445 ] 
            
Jacques Le Roux commented on OFBIZ-510:
---------------------------------------

I think that this is a crucial point. Is DOJO able to "degrade" (what does that mean exactly, I'm not sure) ? Please see Chris's post on dev ML

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458323 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

FYI - http://twpinc.insourcery.com has changed to http://twpjsp.hotwaxmedia.com for anyone who was lookin'

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-510?page=all ]

David E. Jones closed OFBIZ-510.
--------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Thanks Anil, Ashish, Tim, and others who have worked on and commented on this.

The changes along with license notice for dojo are in SVN rev 490651.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Assigned To: David E. Jones
>             Fix For: SVN trunk
>
>         Attachments: Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459107 ] 
            
Anil K Patel commented on OFBIZ-510:
------------------------------------

I never said that this patch includes work that belongs to other issue. In accordance with what you said regarding adding more code and files so we don't break other function I added this extra method in this file. Eventually this this method can be used to replace other the other methods that exists in Ofbiz that do something similar.  One of the other bad thing about this code is it just almost replicates method that already exists in the same file. If you look at the code in createCustomer method, its almost replica of createUser method that exists in Party component. I have documented these things in the Issue Ofbiz-512. All this code is result of general practice of adding new things and not removing old stuff and creating redundent code. Yes I have added redundancy, Just to prove my good intentions I have also created a Jira Issue to discuss the problem and find a  better solution to fix the problem.

Processing Payment using async call is lot friendly then doing a full page submit. In the next step we are planning to offer async shipping estimate to user as first step of checkout. While we are contributing our work for review to the community, people can definitely use little polite words to express their ideas.



  

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12460619 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

Alex, thanks for your kind words, but I deserve very little of the praise.  I'm currently testing a two step process that will actually improve upon the 3 step - we'll see how it goes and we'll put another patch out there for testing.  At that point, it'll be time to get it checked in and allow everyone to run with it.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459104 ] 
            
Anil K Patel commented on OFBIZ-510:
------------------------------------

Chris,
The createUpdateUser method in CustomeEvents.xml file is doing same thing what has been done at three other places. While working on this I created issue,  Please refer to http://issues.apache.org/jira/browse/OFBIZ-512 for some information that I have documented. With time I wish to break it down into smaller methods as you suggested (at a point in development it was like collection of method calls) and move this method and related view components to Party component. Hopefully this refactoring consolidate party management methods.  I will appreciate your feedback in this effort. I personally find create Party/Customer/Employee etc screens in Party manager are very unfriendly. 

In the Order review screen related code. It is very easy to add new files. I thought it will to add more maintenance. In this whole task, more time is spent on cleanup then really adding new functionality. 

Ajax Implementation, Please correct If I am not wrong, the javascript framework file will be chached by the browser, So it should be one time load. If other section of ecommerce site decided to use it, we can take advantage of this 150Kb download. I see ajax getting used for improving user shopping experience and not just checkout process.

In the final order review screen, the Payment form is processed async and finally order is sibmitted only if payment process is completed.


   

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459106 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

Chris, thanks for taking the time to review this so carefully - it's nice to have people sanity checking these issues.  

Now, I'm going to have to disagree with you on the Screen consolidation issues.  You must not have looked at the last patch very closely that got committed - this is an entirely NEW checkout process that's being created in hopes to make it MUCH easier for people to customize this process in the future.  This is somethng that the community has been pining for for a long time and I'm really stoked that we're going to be able to give that to them.

That being said, things change in OFBiz all the time - and unless you blindly updating without watching what is changing in the project, then you should be able to follow how things are evolving.  And that's just my point, this process is evolving - and AJAX happens to be something that's time has come.  I agree that for this particular piece of functionality, there is a possibility to do this without using AJAX, but this is one step in a further evolution of making the usage of the OFBiz eCommerce app much cleaner - and that will probably include some work done with an AJAX toolkit.

I think it's a little lame to be sticking it to people and saying that someone's complicating the issue in order to use a buzzword.  A lot of work has been done to make this process better for the community at large - and there are potentially other tactics to use other than slamming someone for their choices.  This happens to be a place that does not benefit directly, but as it becomes a part of a larger process that's being revamped, you may indeed see the benefit.

Let's get a vote together sometime soon.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Alex D. Fleming (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12460611 ] 
            
Alex D. Fleming commented on OFBIZ-510:
---------------------------------------

Hi Tim,

I have tested the patch : Anon_Checkout_3_and_6_step_combined_simultaneous.patch.
It looks excellent to me.
I appreciate the 3 step anonymous checkout process and inbuilt use of Dojo toolkit in it.

It's really benifical to keep 6 as well as the 3 step anonymous checkout in the SVN repository.
Thanks Tim for your nice work.

Cheers
Alex D. Fleming


> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12461136 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

I believe that we can delete the other patches that were provided:

1. 3stepAnonCheckoutWithAjax.patch (335 kb)
2. Anon_Checkout_2_and_6_step_combined_simultaneous.patch (288 kb) - the old one
3. Anon_Checkout_3_and_6_step_combined_simultaneous.patch (296 kb) - the really old one

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch, Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458503 ] 
            
Jacques Le Roux commented on OFBIZ-510:
---------------------------------------

Tim,

Please forget it Chris has well explained "degrade" in the sense Dojo  uses it in his last mail in dev ML. I was thinking of something more automatic, surely a dream ;o) But the concept is interesting...

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458496 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

What Chris is getting at with the question of what happens if JavaScript is turned off is wondering if the checkout process would then not function correctly because of no JavaScript - and the answer is no it does not work.

My last comment though was meant to underscore the fact that unless they turned off JavaScript while they were in the checkout process, they could not get to the checkout process because JavaScript is needed to purchase the products.  Try buying something from "Featured Products", with the direct "Add to Cart" link, with JavaScript turned off and you'll see what I mean.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458326 ] 
            
Chris Howe commented on OFBIZ-510:
----------------------------------

I'm interested in checking this out.  Before I set aside some time.  If Javascript is turned of in the user's browser, will this continue with the old mechanism of anonymous checkout?

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-510?page=all ]

David E. Jones reassigned OFBIZ-510:
------------------------------------

    Assignee: David E. Jones

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Assigned To: David E. Jones
>         Attachments: Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458406 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

Chris, to your point, I figured I'd go ahead and check out what _does_ happen when there's no JavaScript enabled. 

I turned off JavaScript in Safari, and then went to a local install and I couldn't even put anything in the cart!!  Then I went to JIRA to answer this comment - and I couldn't add a comment!!  So, I'm hoping that this isn't a requirement or we're pretty screwed :)   

Anybody get a chance to check this out ?  What do we think?

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-510?page=all ]

Tim Ruppert updated OFBIZ-510:
------------------------------

    Attachment: Anon_Checkout_2_and_6_step_combined_simultaneous.patch

This latest patch fixes the last issue that we could find in the quick anonymous checkout process - not checking for a shipment method being provided.  It also updates the order total inline as a result of this. 

Let's get this in there now as it's a really nice upgrade to the existing processes and gives A LOT more flexibility for the community going forward.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch, Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_2_and_6_step_combined_simultaneous.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458325 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

We are planning on doing the next step - pushing the Shipping Estimator out to the Shopping Cart immediately following this - but it's unclear how many people would actually want this in their application as it requires a commercial web service to translate from Zip Code to enough of an address for UPS estimates (which is what my customer is looking for).

We'd be happy to share, but I doubt this will make it back in it's entirety.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-510?page=all ]

Tim Ruppert updated OFBIZ-510:
------------------------------

    Attachment: Anon_Checkout_3_and_6_step_combined_simultaneous.patch

Great work guys.  We have updated the patch to have both anonymous checkout processes working simultaneously.  There are a few quick things that need to be updated:

Move these files from applications/ecommerce/webapp/ecommerce/includes to applications/ecommerce/webapp/ecommerce/order

1. ccinfo.ftl
2. gcinfo.ftl
3. eftinfo.ftl

Combine the second step (shipping options) on to the Review Screen.  As for where to put it, just expand out the area where the shipment information is currently shown - to show the options.  Use two columns if necessary.  

This will result in two screens - the Personal Info screen and the Review Order / Payment Information /. Shipping Options screen.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch, Anon_Checkout_3_and_6_step_combined_simultaneous.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Tim Ruppert (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12454673 ] 
            
Tim Ruppert commented on OFBIZ-510:
-----------------------------------

Daniel, I will look into this stuff later today / tonite - thanks for responding so quickly.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12458501 ] 
            
Jacques Le Roux commented on OFBIZ-510:
---------------------------------------

Thanks Chris,

However Chris's mail in dev ML I was referring to was :

<<I'm not sure about the other toolkits, but when I
looked around for some implementation ideas, I like
the fact that one of Dojo's precepts is to degrade
when not JS is turned off.  This may be true of other
toolkits as well, but Dojo states it specifically>

So my question was (I don't know Dojo) what means exactly "degrade" here. Is there an existing mechanism in DOjo that help (may be used?)  to switch operations without js if js is not present ?

Anyway I guess we must think about people not haing js on their machines (future pocket machine ?) or even don't want to let js interfere (has turned if off)...

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-510) Anonymous Checkout Refactoring [ ecommerce ] Part #2

Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/OFBIZ-510?page=comments#action_12459099 ] 
            
Chris Howe commented on OFBIZ-510:
----------------------------------

I finally had a chance to thoroughly review this patch and it looks very nice.  I really like the effort of consolidating the checkout process but at the same time keeping those pages from being too busy.

The patch really feels like it's trying to accomplish two seperate things though, a screen consolidation and then an ajax implementation.  I have a bit of constructive criticism on both.  Let me address them separately.

Screen consolidation:
There is rewrite of sorts for CustomerEvents.xml.  I'm not sure the reason or need for this.  Many people utilize those simple methods and changing their functionality and their method names would most likely break anyone's deployment that utilizes ecommerce.  Perhaps a better approach would be to break up the existing simple methods into smaller chuncks where the parent method is calling the smaller chunks. For instnace

myMethod
a
b
c

turns into:
myMethod
calls methodA
calls methodB
calls methodC

methodA
...

methodB
...

methodC
...

then you can utilize the chunks you need to accomplish your tasks and won't interfere with others.

A similar thing was occurring with OrderScreens.xml.  You shouldn't remove/change a screen that someone else may be using.  Create your new screen(s) and simply change the controller.xml to point to it instead.  Then in a later effort a cleanup can be done.  This helps keep the component customizable and functional with simple changes.

AJAX implementation:
While this works well, it appears to be very unnecessary.  The async call is specifically what is keeping this from having the potential to degrade.  This same effect can be accomplished with just javascript in a visible/invisible dynamically changing of the css class for the div.  You're having the client download a 150+KB JS framework in order to potentially save them from downloading 5-7KB of html.

> Anonymous Checkout Refactoring [ ecommerce ] Part #2
> ----------------------------------------------------
>
>                 Key: OFBIZ-510
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-510
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Attachments: 3stepAnonCheckoutWithAjax.patch
>
>
> So, now that we're close to completing the Anonymous Checkout Refactoring Part #1, we are going on to the second phase out of three, which is intended to make the checkout process even more succint.  The final goal is to do something like I did for one of my customers - http://twpinc.insourcery.com .  This is an old site and is being replaced, so don't worry about the other functionality - just walk thru the checkout process.
> Currently we have a long process that contains these functions / screens:
> 1. Personal Info
> 2. Shipping Address
> 3. Shipping Options
> 4. Payment Options
> 5. Payment Information (and Billing Address)
> 6. Review Order
> 7. Order Confirmation
> We are going to shorten it up this way:
> 1. Personal Info / Shipping Address / Billing Address - with the appropriate error handling and the check box & action Billing same as shipping)
> 2. Shippint Options 
> 3. Payment Options (if necessary - skip if you only have credit card - or only one option in general)
> 4. Review & Place Order - enter the credit card right here - put error handling here as well
> 5. Order Confirmation
> This would be the end of this patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira