[GitHub] dgrove-oss commented on a change in pull request #223: Deploy Kafka package and provider with Helm

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #223: Deploy Kafka package and provider with Helm
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/223#discussion_r195470002
 
 

 ##########
 File path: helm/templates/installPkgKafkaJob.yaml
 ##########
 @@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
+apiVersion: batch/v1
+kind: Job
+metadata:
+  name: install-package-kafka
+  namespace: {{ .Release.Namespace | quote }}
+spec:
+  activeDeadlineSeconds: 600
+  template:
+    metadata:
+      name: install-package-kafka
+    spec:
+      restartPolicy: Never
+      initContainers:
+      # Wait for a controller to be up so we can perfom our CRUD actions with the CLI
+{{ include "readiness.waitForController" . | indent 6 }}
+      containers:
+      - name: kafkapkginstaller
+        image: openwhisk/kube-kafkapkginstaller
+        env:
+          - name: "AUTH"
+            valueFrom:
+              secretKeyRef:
+                name: whisk.auth
+                key: system
+          # poorly named envvar; actually expects full apihost (host:port)
+          - name: "APIHOST"
+            value: "{{- .Values.whisk.ingress.api_host_name -}}:{{- .Values.whisk.ingress.api_host_port -}}"
+          # for the database used by kafka package
+          - name: "DB_HOST"
+            value: $(COUCHDB_SERVICE_HOST)
 
 Review comment:
   database may be external to the cluster, so instead say
   
   `value: {{ include "db_host" . | quote }}`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services