You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/13 03:51:44 UTC
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #758: fix #750. registry center notify with complete address list
codecov-io edited a comment on pull request #758:
URL: https://github.com/apache/dubbo-go/pull/758#issuecomment-726488883
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=h1) Report
> Merging [#758](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=desc) (51ee140) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e11faed28e4d6c036b5c55bc65c8d7b42af4f0ec?el=desc) (e11faed) will **increase** coverage by `0.35%`.
> The diff coverage is `60.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/758/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #758 +/- ##
===========================================
+ Coverage 59.91% 60.26% +0.35%
===========================================
Files 260 260
Lines 12807 12829 +22
===========================================
+ Hits 7673 7732 +59
+ Misses 4177 4137 -40
- Partials 957 960 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `60.33% <ø> (+0.98%)` | :arrow_up: |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.21% <0.00%> (-0.86%)` | :arrow_down: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `80.90% <70.58%> (+6.89%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+0.88%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `51.42% <0.00%> (+5.30%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/758/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=footer). Last update [e11faed...51ee140](https://codecov.io/gh/apache/dubbo-go/pull/758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org