[jira] [Commented] (TOMEE-2292) MicroProfile Config Example

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TOMEE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714581#comment-16714581 ] 

ASF GitHub Bot commented on TOMEE-2292:
---------------------------------------

Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/220#discussion_r240168601
  
    --- Diff: examples/mp-config-example/pom.xml ---
    @@ -0,0 +1,72 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0"
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +    <parent>
    --- End diff --
    
    Hi Daniel, 
    Thanks for your PR.
    Can you please make the example work without a Parent definition? Please check: https://github.com/apache/tomee/blob/master/examples/README.adoc


> MicroProfile Config Example
> ---------------------------
>
>                 Key: TOMEE-2292
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2292
>             Project: TomEE
>          Issue Type: Sub-task
>          Components: Examples and Documentation
>    Affects Versions: 8.0.0-M1
>            Reporter: Daniel Cunha
>            Assignee: Jonathan Gallimore
>            Priority: Minor
>              Labels: examples, pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)