You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/16 19:53:37 UTC

[GitHub] [arrow] BatmanAoD opened a new pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

BatmanAoD opened a new pull request #8206:
URL: https://github.com/apache/arrow/pull/8206


   This is based on my [proof-of-concept](https://github.com/BatmanAoD/arrow-rust-specialization-alternatives/pull/1).
   
   There are currently some test failures. I will move this out of 'draft' status when they are fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] sunchao commented on pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #8206:
URL: https://github.com/apache/arrow/pull/8206#issuecomment-701553472


   Just found out this... Nice work @BatmanAoD !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] BatmanAoD commented on a change in pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

Posted by GitBox <gi...@apache.org>.
BatmanAoD commented on a change in pull request #8206:
URL: https://github.com/apache/arrow/pull/8206#discussion_r489732058



##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -208,12 +210,22 @@ pub trait ArrowPrimitiveType: 'static {
     fn get_data_type() -> DataType;
 
     /// Returns the bit width of this primitive type.
-    fn get_bit_width() -> usize;
+    fn get_bit_width() -> usize {
+        size_of::<Self::Native>()

Review comment:
       ```suggestion
           size_of::<Self::Native>() * 8
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8206:
URL: https://github.com/apache/arrow/pull/8206#issuecomment-694612173


   Test failures are unrelated (conda integration tests)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8206:
URL: https://github.com/apache/arrow/pull/8206#issuecomment-693636874


   https://issues.apache.org/jira/browse/ARROW-10002


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove closed pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8206:
URL: https://github.com/apache/arrow/pull/8206


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8206:
URL: https://github.com/apache/arrow/pull/8206#issuecomment-694613350


   🎉  this is highly appreciated, and the API is also easier to work with.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #8206: ARROW-10002: [Rust] Remove `default fn` from `PrimitiveArrayOps`

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8206:
URL: https://github.com/apache/arrow/pull/8206#issuecomment-694504625


   @BatmanAoD Could you rebase against master (not merge) and I can merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org