You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/29 15:09:59 UTC
[GitHub] [incubator-nuttx-apps] juniskane opened a new pull request #909: testing/ostest: remove spurious redefinitions of NULL
juniskane opened a new pull request #909:
URL: https://github.com/apache/incubator-nuttx-apps/pull/909
## Summary
Macro NULL is defined in multiple standard library headers, including <stdio.h> which is included by ostest source files, on all POSIX-conformant systems. Since the purpose of testing suites is to find errors, it makes no sense for them to try to "fix" broken headers missing normal functionality. This PR removes such kludges. Much better if test suite fails compilation if there is a problem with libc header files.
Also C++ defines NULL as 0, not (void *)0.
## Impact
N/A
## Testing
ostest still passes on my systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #909: testing/ostest: remove spurious redefinitions of NULL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #909:
URL: https://github.com/apache/incubator-nuttx-apps/pull/909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org