[GitHub] [apisix-ingress-controller] tokers commented on issue #133: Refactor: Optimize process of resources push to APISIX

[GitBox <gi...@apache.org>]

tokers commented on issue #133:
URL: https://github.com/apache/apisix-ingress-controller/issues/133#issuecomment-751931916


   > The sequential codes just keep the order upstream -> service -> route, which is not enough. When deleting resources, the order is reversed. The orders is different in different the operation type .
   
   The current event-based notification also is hard coded since the order is fixed just like the sequential way.
   Actually i have another idea about to abstract the dependency, but i think it's over design, so what i pasted here is the sequential way, just rewriting the implementation, but keep this fixed order.
   
   > Another question is , Is ResourcesChange a global Object ? As what you said the whole apply process can not be atomic, It will cause race here.
   
   Nope, a `ResourceChange` object will be created once we need to generate a resource push event.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org