You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2015/03/28 01:05:21 UTC

[44/50] incubator-kylin git commit: KYLIN-653 minor change

KYLIN-653 minor change


Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/cff578a7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/cff578a7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/cff578a7

Branch: refs/heads/streaming-localdict
Commit: cff578a7df8e75b07caf4f21803f0426aa94485e
Parents: a36d416
Author: honma <ho...@ebay.com>
Authored: Fri Mar 27 18:05:23 2015 +0800
Committer: honma <ho...@ebay.com>
Committed: Fri Mar 27 18:06:19 2015 +0800

----------------------------------------------------------------------
 .../main/java/org/apache/kylin/job/cube/CubingJobBuilder.java | 2 --
 .../java/org/apache/kylin/job/BuildCubeWithEngineTest.java    | 7 ++-----
 .../apache/kylin/job/hadoop/invertedindex/II2CubeTest.java    | 2 ++
 3 files changed, 4 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/cff578a7/job/src/main/java/org/apache/kylin/job/cube/CubingJobBuilder.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/org/apache/kylin/job/cube/CubingJobBuilder.java b/job/src/main/java/org/apache/kylin/job/cube/CubingJobBuilder.java
index 278f4dd..7cde298 100644
--- a/job/src/main/java/org/apache/kylin/job/cube/CubingJobBuilder.java
+++ b/job/src/main/java/org/apache/kylin/job/cube/CubingJobBuilder.java
@@ -170,9 +170,7 @@ public final class CubingJobBuilder extends AbstractJobBuilder {
 
         final AbstractExecutable intermediateHiveTableStep = createIntermediateHiveTableStep(intermediateTableDesc, jobId);
         result.addTask(intermediateHiveTableStep);
-
         result.addTask(createFactDistinctColumnsStep(seg, intermediateHiveTableName, jobId));
-
         result.addTask(createBuildDictionaryStep(seg, factDistinctColumnsPath));
         MapReduceExecutable baseCuboidStep = null;
         if(!useImMemCubing) {

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/cff578a7/job/src/test/java/org/apache/kylin/job/BuildCubeWithEngineTest.java
----------------------------------------------------------------------
diff --git a/job/src/test/java/org/apache/kylin/job/BuildCubeWithEngineTest.java b/job/src/test/java/org/apache/kylin/job/BuildCubeWithEngineTest.java
index a33dab5..dc2f74f 100644
--- a/job/src/test/java/org/apache/kylin/job/BuildCubeWithEngineTest.java
+++ b/job/src/test/java/org/apache/kylin/job/BuildCubeWithEngineTest.java
@@ -51,16 +51,13 @@ import static org.junit.Assert.assertEquals;
 
 public class BuildCubeWithEngineTest {
 
-    private JobEngineConfig jobEngineConfig;
+    private static final Log logger = LogFactory.getLog(BuildCubeWithEngineTest.class);
 
+    private JobEngineConfig jobEngineConfig;
     private CubeManager cubeManager;
-
     private DefaultScheduler scheduler;
-
     protected ExecutableManager jobService;
 
-    private static final Log logger = LogFactory.getLog(BuildCubeWithEngineTest.class);
-
     protected void waitForJob(String jobId) {
         while (true) {
             AbstractExecutable job = jobService.getJob(jobId);

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/cff578a7/job/src/test/java/org/apache/kylin/job/hadoop/invertedindex/II2CubeTest.java
----------------------------------------------------------------------
diff --git a/job/src/test/java/org/apache/kylin/job/hadoop/invertedindex/II2CubeTest.java b/job/src/test/java/org/apache/kylin/job/hadoop/invertedindex/II2CubeTest.java
index da1cb18..080da1b 100644
--- a/job/src/test/java/org/apache/kylin/job/hadoop/invertedindex/II2CubeTest.java
+++ b/job/src/test/java/org/apache/kylin/job/hadoop/invertedindex/II2CubeTest.java
@@ -22,6 +22,7 @@ import org.apache.kylin.invertedindex.index.TableRecordInfoDigest;
 import org.apache.kylin.invertedindex.model.*;
 import org.apache.kylin.job.constant.BatchConstants;
 import org.apache.kylin.job.hadoop.cube.FactDistinctIIColumnsMapper;
+import org.apache.kylin.job.hadoop.cube.IIToBaseCuboidMapper;
 import org.apache.kylin.streaming.Stream;
 import org.apache.kylin.streaming.StringStreamParser;
 import org.apache.kylin.streaming.invertedindex.SliceBuilder;
@@ -133,4 +134,5 @@ public class II2CubeTest extends LocalFileMetadataTestCase {
             Assert.assertTrue(lstgNames.contains(pair.getSecond().toString()));
         }
     }
+
 }