[GitHub] [maven] ewiegs4 commented on issue #289: [MNG-6772] - Prevent Super POM central entry from overriding

[GitBox <gi...@apache.org>]

ewiegs4 commented on issue #289: [MNG-6772] - Prevent Super POM central entry from overriding
URL: https://github.com/apache/maven/pull/289#issuecomment-538454631
 
 
   We could, but I believe the Super POM's repositories are the only ones affected, as the `DefaultModelBuilder` [breaks before configuring the resolver with its repositories](https://github.com/apache/maven/blob/38efe8444c91e7c1dbf489bc672841c9458ae9ec/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java#L330-L335), so all other repositories will be added to the resolver prior to interpolation and then [overwritten after interpolation](https://github.com/apache/maven/blob/38efe8444c91e7c1dbf489bc672841c9458ae9ec/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java#L410-L411), but the repositories from the Super POM will only be added after interpolation if there isn't already a `central` repository defined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services