matzew's r421499 (July 12th) commit broke t:popup on July

[Mike Kienenberger <mk...@gmail.com>]

I had an end-user report that popups weren't working.   It took me
several hours to track down when it was broken.

Two committers have worked on the code and neither of them verified
that the simple popup examples were working after making changes.

Author: matzew
Date: Wed Jul 12 22:19:04 2006
New Revision: 421499

Author: matzew
Date: Wed Jul 12 22:19:04 2006
New Revision: 421499

Author: imario
Date: Tue Jul 25 10:21:13 2006
New Revision: 425463

Re: matzew's r421499 (July 12th) commit broke t:popup on July

[Wendy Smoak <ws...@gmail.com>]

On 9/3/06, Mike Kienenberger <mk...@gmail.com> wrote:

> That was the same behavior I saw -- t:popups with no manual id value
> didn't work.

Oh, I didn't realize the problem was related to not having an id.

I added ids so I could tell Selenium to mouseOver a certain span, so I
effectively "fixed" the example.  I left those, but added another line
of 'text with no id' that I'll try to figure out how to test.
Meanwhile, it's there to click through (or hover over, as the case may
be.)

-- 
Wendy

Re: matzew's r421499 (July 12th) commit broke t:popup on July

[Mike Kienenberger <mk...@gmail.com>]

Hi Wendy,

That was the same behavior I saw -- t:popups with no manual id value
didn't work.

On 9/3/06, Wendy Smoak <ws...@gmail.com> wrote:
> On 8/31/06, Mike Kienenberger <mk...@gmail.com> wrote:
>
> > I had an end-user report that popups weren't working.   It took me
> > several hours to track down when it was broken.
>
> Mike, can you describe the broken behavior?
>
> What I see in (an older version of) myfaces-example-simple/popup.jsf
> is that the 'Text Popup 1' works if you hover over the span containing
> "This is the first textual text situation." on the first line, but the
> popups for the second and third lines don't work.
>
> In r439718 I added a Selenium test to make sure that the popup works
> on all three lines of text.  (Also, we're getting closer to automated
> tests for the components, I'll post another message about that.)
>
> --
> Wendy
>

Re: matzew's r421499 (July 12th) commit broke t:popup on July

[Wendy Smoak <ws...@gmail.com>]

On 8/31/06, Mike Kienenberger <mk...@gmail.com> wrote:

> I had an end-user report that popups weren't working.   It took me
> several hours to track down when it was broken.

Mike, can you describe the broken behavior?

What I see in (an older version of) myfaces-example-simple/popup.jsf
is that the 'Text Popup 1' works if you hover over the span containing
"This is the first textual text situation." on the first line, but the
popups for the second and third lines don't work.

In r439718 I added a Selenium test to make sure that the popup works
on all three lines of text.  (Also, we're getting closer to automated
tests for the components, I'll post another message about that.)

-- 
Wendy

Re: matzew's r421499 (July 12th) commit broke t:popup on July

[Matthias Wessendorf <ma...@apache.org>]

fixed bad boy's 421499 commit
(undo).

On 8/31/06, Mike Kienenberger <mk...@gmail.com> wrote:
> I had an end-user report that popups weren't working.   It took me
> several hours to track down when it was broken.
>
> Two committers have worked on the code and neither of them verified
> that the simple popup examples were working after making changes.
>
> Author: matzew
> Date: Wed Jul 12 22:19:04 2006
> New Revision: 421499
>
> Author: matzew
> Date: Wed Jul 12 22:19:04 2006
> New Revision: 421499
>
> Author: imario
> Date: Tue Jul 25 10:21:13 2006
> New Revision: 425463
>


-- 
Matthias Wessendorf

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com