[GitHub] [nifi] markap14 commented on issue #3894: NIFI-6884 - Native library loading fixed/improved

[GitBox <gi...@apache.org>]

markap14 commented on issue #3894: NIFI-6884 - Native library loading fixed/improved
URL: https://github.com/apache/nifi/pull/3894#issuecomment-557585203
 
 
   Thanks for the responses @tpalfy! I realize, as I reviewed again, that my comments may have come off in a bit of a "This has to change, this has to change, this has to change!" tone. My apologies, if that's the case. I just started a review and commented on things that I noticed as I read through, a bit of a stream of thoughts. This resulted in some comments being rather nit-picky, was just mentioning anything that stuck out to me.
   
   And thanks @turcsanyip for reviewing as well! And for explaining how you tested. My biggest concern was that I didn't have a good way to easily test this, which is why I was suggesting the integration test. I do think that an integration test for this would be ideal and would be helpful to avoid breaking things going forward. However, I realize that providing an integration test is a tall order, and it's not something that necessarily has to be done before merging this PR - as long as we have a clear way of testing this. So thanks for outlining that!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services