You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Jim Riggs (JIRA)" <ji...@apache.org> on 2013/08/07 04:32:49 UTC

[jira] [Updated] (TS-1823) config file line continuation support

     [ https://issues.apache.org/jira/browse/TS-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Riggs updated TS-1823:
--------------------------

    Attachment: 0001-Add-line-continuation-to-remap.config-using-a-backsl.patch

Add line continuation to remap.config using a backslash at the end of a line as the continuation character.

The handling for continuation was made in tokLine() by adding an optional third char parameter (`cont') which is the continuation character. This should make it usable in other contexts outside of remap.config also, for example other config file parsers.

This implementation is not very intelligent, as it only checks for the backslash immediately preceding the newline and does not handle any whitespace. The backslash and newline are converted into spaces, and the next line is appended.

Example:

{code}
.definefilter foo \
  @action=allow \
  @src_ip=127.0.0.1
{code}

is read and parsed in UrlRewrite::BuildTable() as:

{code}
.definefilter foo     @action=allow     @src_ip=127.0.0.1
{code}

                
> config file line continuation support
> -------------------------------------
>
>                 Key: TS-1823
>                 URL: https://issues.apache.org/jira/browse/TS-1823
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Configuration
>            Reporter: James Peach
>             Fix For: 3.5.0
>
>         Attachments: 0001-Add-line-continuation-to-remap.config-using-a-backsl.patch
>
>
> It looks like remap.config does not support line continuation. We should add generic line continuation support so that all config files get it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira