You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 20:19:48 UTC

[GitHub] [airflow] gmcrocetti commented on pull request #25494: `AwsBaseHook` not using Connection's host

gmcrocetti commented on PR #25494:
URL: https://github.com/apache/airflow/pull/25494#issuecomment-1204433467

   > 
   
   Hi @Taragolis . I do agree that `endpoint_url` is way more intuitive than `host`, as thus we should deprecated both `host` and `extra["host"]` toward a more lean alternative. The problem is this is my biased developer POV and I don't know how airflow's community will react to that (they're used with the host field after all).
   I'll mark @potiuk to provide some guidance in here. I'm either ok with closing this PR (and the related issue) or working in the `endpoint_url` suggestion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org