You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@activemq.apache.org by "Timothy Bish (JIRA)" <ji...@apache.org> on 2017/10/06 13:51:02 UTC

[jira] [Commented] (AMQ-6828) Improvement to python AMQP example

    [ https://issues.apache.org/jira/browse/AMQ-6828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194606#comment-16194606 ] 

Timothy Bish commented on AMQ-6828:
-----------------------------------

First thing I see is that your patch is messing with dependency versions in the project pom file which it shouldn't.  If you want to also accept pull requests via Github which might help you there as you rebase on master before sending the PR for the changes.

> Improvement to python AMQP example
> ----------------------------------
>
>                 Key: AMQ-6828
>                 URL: https://issues.apache.org/jira/browse/AMQ-6828
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: AMQP, Samples
>    Affects Versions: 5.15.1
>            Reporter: James Sears
>            Priority: Trivial
>         Attachments: patchfile.txt
>
>
> The AMQP python example has a defect – it doesn’t dequeue - and is pre-python 3 syntax.
> Find attached a patch for replacing listener.py & publisher.py
> PS – the patch includes a grammer fix assembly/src/release/examples/amqp/java/readme.md



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)