You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2005/05/10 11:29:04 UTC

DO NOT REPLY [Bug 33630] - FormBean support simple type Formats like 'int' and 'long' handled incorrectly - at least attempt a trim()

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33630>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33630


hauser@acm.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hauser@acm.org
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |
            Summary|FormBean support simple type|FormBean support simple type
                   |Formats like 'int' and      |Formats like 'int' and
                   |'long' handled incorrectly  |'long' handled incorrectly -
                   |                            |at least attempt a trim()




------- Additional Comments From hauser@acm.org  2005-05-10 11:28 -------
one improvement that could be done as a minimum is that before setting e.g. a
long value to "0" and subsequently succeed at the corresponding "long"-validator
as a "false positive", at least trim() the string before doing so

Sample test case for a Long Form-Bean Attribute:
- observed behaviour: "0302 0100002" will be set to 0 and then pass the "long" test.
- expected behaviour: trim() and then succeed with "03020100002" or rather
"3020100002" - in other cases, at least transport the erroneous value to the
validator such that the end-user will see the "errors.long" error message.

Otherwise, struts better ought to remove the 
<validator name="long"
            classname="org.apache.struts.validator.FieldChecks"
               method="validateLong"
         methodParams="java.lang.Object,
                       org.apache.commons.validator.ValidatorAction,
                       org.apache.commons.validator.Field,
                       org.apache.struts.action.ActionMessages,
                       javax.servlet.http.HttpServletRequest"
              depends=""
                  msg="errors.long"/>
from the validator-rules.xml

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org