You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/06 14:36:52 UTC
[GitHub] [incubator-seatunnel] laglangyue opened a new pull request, #2664: [Improve] improve sub-module name of e2e
laglangyue opened a new pull request, #2664:
URL: https://github.com/apache/incubator-seatunnel/pull/2664
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
close #2661
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue closed pull request #2664: [Improve] improve sub-module name of e2e
Posted by GitBox <gi...@apache.org>.
laglangyue closed pull request #2664: [Improve] improve sub-module name of e2e
URL: https://github.com/apache/incubator-seatunnel/pull/2664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2664: [Improve] improve sub-module name of e2e
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2664:
URL: https://github.com/apache/incubator-seatunnel/pull/2664#issuecomment-1238840204
e2e-module naming style reference:
connector-v2
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-connectors-v2
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-flink-connector-v2-e2e
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-spark-connector-v2-e2e
connector-v1 flink
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-connectors/seatunnel-connectors-flink
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-flink-e2e
connector-v1 flink sql
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-connectors/seatunnel-connectors-flink-sql
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-flink-sql-e2e
connector-v1 spark
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-connectors/seatunnel-connectors-spark
- https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-spark-e2e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2664: [Improve] improve sub-module name of e2e
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2664:
URL: https://github.com/apache/incubator-seatunnel/pull/2664#issuecomment-1238797987
I think datasource type should be the first word of sub module name
---Original---
From: ***@***.***>
Date: Wed, Sep 7, 2022 01:25 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/incubator-seatunnel] [Improve] improve sub-module name ofe2e (PR #2664)
This is useless, keep the original name is the best choice. What do you think about it? @hailin0 @CalvinKirs
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2664: [Improve] improve sub-module name of e2e
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2664:
URL: https://github.com/apache/incubator-seatunnel/pull/2664#issuecomment-1238450705
This is useless, keep the original name is the best choice. What do you think about it? @hailin0 @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org