[GitHub] [incubator-iceberg] aokolnychyi commented on issue #686: Add transform expressions

[GitBox <gi...@apache.org>]

aokolnychyi commented on issue #686: Add transform expressions
URL: https://github.com/apache/incubator-iceberg/pull/686#issuecomment-570546754
 
 
   I went through the changes in this PR. Indeed, it became much cleaner. Thanks, @rdblue!
   
   A couple of follow-up questions:
   - `UnboundTransform` contains a TODO to avoid using toString/fromString for transforms. What is our desired way of doing this?
   - Transforms always assume they operate on one column, which is not necessarily the case. It seems support for transforms that have multiple source columns (e.g. multidimensional clustering) will be a major breaking change. Do we want to delay that until we have an actual need?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org