You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/02 10:23:11 UTC

[GitHub] [incubator-superset] villebro commented on a change in pull request #9962: feat: implement new version of word cloud

villebro commented on a change in pull request #9962:
URL: https://github.com/apache/incubator-superset/pull/9962#discussion_r433773845



##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/index.test.js
##########
@@ -23,7 +23,7 @@ import DashboardFilterTest from './filter';
 import DashboardLoadTest from './load';
 import DashboardSaveTest from './save';
 import DashboardTabsTest from './tabs';
-import DashboardUrlParamsTest from './url_params';
+import DashboardFormDataTest from './url_params';

Review comment:
       I tried to rename this file to `formData.js`, but a recently added linting rule preferring TypeScript threw a weird exception that I didn't have time to debug now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org