You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/17 01:54:35 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3479: [Enhancement] Do some code optimization[ProducerImpl]

Alonexc opened a new issue, #3479:
URL: https://github.com/apache/incubator-eventmesh/issues/3479

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/225791404-8b68f66d-0236-4daf-803d-0e4f58ce5644.png)
   ![image](https://user-images.githubusercontent.com/91315508/225791410-e3b3af38-040f-49ed-bd45-b61b9a442d9c.png)
   ![image](https://user-images.githubusercontent.com/91315508/225791414-f98d6490-61c6-4c73-a360-1bf96d736ddc.png)
   located at:
   eventmesh-connector-plugin/eventmesh-connector-kafka/src/main/java/org/apache/eventmesh/connector/kafka/producer/ProducerImpl.java line 47,48,50,92,114
   
   
   ### Describe the solution you'd like
   
   a.add final
   ![image](https://user-images.githubusercontent.com/91315508/225791458-f332e8a2-3dac-461d-90bf-9694c4bce15a.png)
   
   b. Use try-with-resources or close this "Admin" in a "finally" clause.
   ![image](https://user-images.githubusercontent.com/91315508/225791479-48697156-8c55-42be-992a-0ecb6377b69e.png)
   
   c.use Objects.requireNonNull()
   ![image](https://user-images.githubusercontent.com/91315508/225791491-de32cb2e-3e77-40ed-a9da-8abaac7a46db.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc closed issue #3479: [Enhancement] Do some code optimization[ProducerImpl]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.

Alonexc closed issue #3479: [Enhancement] Do some code optimization[ProducerImpl]
URL: https://github.com/apache/eventmesh/issues/3479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org