[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15385: added doc for numpy operators

[GitBox <gi...@apache.org>]

haojin2 commented on a change in pull request #15385: added doc for numpy operators
URL: https://github.com/apache/incubator-mxnet/pull/15385#discussion_r298424854
 
 

 ##########
 File path: python/mxnet/_numpy_op_doc.py
 ##########
 @@ -176,3 +176,229 @@ def _np_cumsum(a, axis=None, dtype=None, out=None):
         `axis` is not None or `a` is a 1-d array.
     """
     pass
+
+
+def _np_amax(a, axis=None, out=None):
+    r"""
+    amax(a, axis=None, out=None, keepdims=_Null, initial=_Null)
+
+    Return the maximum of an array or maximum along an axis.
+
+    Parameters
+    ----------
+    a : ndarray
+        Input data.
+        Python native iterables not supported.
+
+    axis : None or int or tuple of ints, optional
+        Axis or axes along which to operate. By default, flattened input is
+        used.
+
+        Negative indices not supported.
+
+    out : ndarray, optional
 
 Review comment:
   Is `out` really the 3rd argument of amax for our version? I believe all MXNet operators put `out` in the end, not in the middle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services