You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by mi...@apache.org on 2017/08/15 09:51:38 UTC

[13/16] incubator-weex git commit: * [android] remove some methods

* [android] remove some methods


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/1f028a66
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/1f028a66
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/1f028a66

Branch: refs/heads/0.16-dev
Commit: 1f028a6614266874eaa81304a5859aa4d16a9656
Parents: b80a7b5
Author: misakuo <mi...@apache.org>
Authored: Mon Aug 14 14:48:26 2017 +0800
Committer: misakuo <mi...@apache.org>
Committed: Mon Aug 14 14:48:26 2017 +0800

----------------------------------------------------------------------
 .../taobao/weex/dom/DOMActionContextImpl.java   |  2 +-
 .../java/com/taobao/weex/tracing/WXTracing.java | 27 --------------------
 2 files changed, 1 insertion(+), 28 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/1f028a66/android/sdk/src/main/java/com/taobao/weex/dom/DOMActionContextImpl.java
----------------------------------------------------------------------
diff --git a/android/sdk/src/main/java/com/taobao/weex/dom/DOMActionContextImpl.java b/android/sdk/src/main/java/com/taobao/weex/dom/DOMActionContextImpl.java
index d18cea8..5a2e88d 100644
--- a/android/sdk/src/main/java/com/taobao/weex/dom/DOMActionContextImpl.java
+++ b/android/sdk/src/main/java/com/taobao/weex/dom/DOMActionContextImpl.java
@@ -180,7 +180,7 @@ class DOMActionContextImpl implements DOMActionContext {
 
     if (WXTracing.isAvailable()) {
       WXTracing.TraceEvent batchEvent = WXTracing.newEvent("domBatch", mInstanceId, -1);
-      batchEvent.duration = Stopwatch.nanosToMillis(System.nanoTime() - startNanos);
+      batchEvent.duration = Stopwatch.millisUntilNow(startNanos);
       batchEvent.ts = start;
       batchEvent.ph = "X";
       WXTracing.submit(batchEvent);

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/1f028a66/android/sdk/src/main/java/com/taobao/weex/tracing/WXTracing.java
----------------------------------------------------------------------
diff --git a/android/sdk/src/main/java/com/taobao/weex/tracing/WXTracing.java b/android/sdk/src/main/java/com/taobao/weex/tracing/WXTracing.java
index 7530322..da1fc4f 100644
--- a/android/sdk/src/main/java/com/taobao/weex/tracing/WXTracing.java
+++ b/android/sdk/src/main/java/com/taobao/weex/tracing/WXTracing.java
@@ -26,9 +26,6 @@ import com.taobao.weex.WXSDKManager;
 import com.taobao.weex.adapter.ITracingAdapter;
 import com.taobao.weex.utils.WXLogUtils;
 
-import org.json.JSONException;
-import org.json.JSONObject;
-
 import java.util.Map;
 import java.util.concurrent.atomic.AtomicInteger;
 
@@ -50,9 +47,6 @@ public class WXTracing {
   public static synchronized void submit(TraceEvent event) {
     ITracingAdapter tracingAdapter = WXSDKManager.getInstance().getTracingAdapter();
     if (tracingAdapter != null) {
-      if (event.iid == null) {
-        WXLogUtils.w("WXTracing", "Event " + event.fname + " missing instance id");
-      }
       tracingAdapter.submitTracingEvent(event);
     }
   }
@@ -89,27 +83,6 @@ public class WXTracing {
       tname = currentThreadName();
     }
 
-    public JSONObject toJSONObject() {
-      JSONObject object = new JSONObject();
-      try {
-        object.put("parentId", parentId);
-        object.put("ref", ref);
-        object.put("parentRef", parentRef);
-        object.put("className", classname);
-        object.put("ts", ts);
-        object.put("traceId", traceId);
-        object.put("iid", iid);
-        object.put("duration", duration);
-        object.put("fName", fname);
-        object.put("ph", ph);
-        object.put("name", name);
-        object.put("tName", tname);
-      } catch (JSONException e) {
-        e.printStackTrace();
-      }
-      return object;
-    }
-
     public void submit() {
       if (!submitted) {
         submitted = true;