You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ba...@apache.org on 2008/10/27 12:37:14 UTC
svn commit: r708143 -
/maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java
Author: baerrach
Date: Mon Oct 27 04:37:13 2008
New Revision: 708143
URL: http://svn.apache.org/viewvc?rev=708143&view=rev
Log:
minor printing cleanup lowercased "includes"
fixed javadoc to avoid usage of \/ to instead encode forward slash via HTML character entity reference /
Modified:
maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java
Modified: maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java?rev=708143&r1=708142&r2=708143&view=diff
==============================================================================
--- maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java (original)
+++ maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java Mon Oct 27 04:37:13 2008
@@ -1,6 +1,6 @@
package org.apache.maven.plugin.dependency;
-/*
+/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@@ -16,7 +16,7 @@
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
- * under the License.
+ * under the License.
*/
import java.io.File;
@@ -49,7 +49,7 @@
{
/**
* Used to look up Artifacts in the remote repository.
- *
+ *
* @parameter expression="${component.org.apache.maven.artifact.factory.ArtifactFactory}"
* @required
* @readonly
@@ -58,7 +58,7 @@
/**
* Used to look up Artifacts in the remote repository.
- *
+ *
* @parameter expression="${component.org.apache.maven.artifact.resolver.ArtifactResolver}"
* @required
* @readonly
@@ -67,7 +67,7 @@
/**
* Artifact collector, needed to resolve dependencies.
- *
+ *
* @component role="org.apache.maven.artifact.resolver.ArtifactCollector"
* @required
* @readonly
@@ -84,7 +84,7 @@
/**
* Location of the local repository.
- *
+ *
* @parameter expression="${localRepository}"
* @readonly
* @required
@@ -93,7 +93,7 @@
/**
* List of Remote Repositories used by the resolver
- *
+ *
* @parameter expression="${project.remoteArtifactRepositories}"
* @readonly
* @required
@@ -102,7 +102,7 @@
/**
* To look up Archiver/UnArchiver implementations
- *
+ *
* @parameter expression="${component.org.codehaus.plexus.archiver.manager.ArchiverManager}"
* @required
* @readonly
@@ -111,7 +111,7 @@
/**
* POM
- *
+ *
* @parameter expression="${project}"
* @readonly
* @required
@@ -120,7 +120,7 @@
/**
* Contains the full list of projects in the reactor.
- *
+ *
* @parameter expression="${reactorProjects}"
* @required
* @readonly
@@ -129,7 +129,7 @@
/**
* If the plugin should be silent.
- *
+ *
* @optional
* @since 2.0
* @parameter expression="${silent}"
@@ -139,7 +139,7 @@
/**
* Output absolute filename for resolved artifacts
- *
+ *
* @optional
* @since 2.0
* @parameter expression="${outputAbsoluteArtifactFilename}"
@@ -176,10 +176,10 @@
/**
* Does the actual copy of the file and logging.
- *
+ *
* @param artifact represents the file to copy.
* @param destFile file name of destination file.
- *
+ *
* @throws MojoExecutionException with a message if an
* error occurs.
*/
@@ -209,16 +209,16 @@
/**
* Unpacks the archive file.
- *
+ *
* @param file File to be unpacked.
* @param location Location where to put the unpacked
* files.
* @param includes Comma separated list of file patterns
- * to include i.e. **\/*.xml,
- * **\/*.properties
+ * to include i.e. **/.xml,
+ * **/*.properties
* @param excludes Comma separated list of file patterns
- * to exclude i.e. **\/*.xml,
- * **\/*.properties
+ * to exclude i.e. **/*.xml,
+ * **/*.properties
*/
protected void unpack ( File file, File location, String includes, String excludes )
throws MojoExecutionException
@@ -227,7 +227,7 @@
{
getLog().info(
"Unpacking " + file.getPath() + " to\n " + location.getPath()
- + "\n with Includes " + includes + " and excludes:" + excludes );
+ + "\n with includes " + includes + " and excludes:" + excludes );
location.mkdirs();
Re: svn commit: r708143 - /maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java
Posted by Barrie Treloar <ba...@gmail.com>.
On Tue, Oct 28, 2008 at 5:49 AM, Brian E. Fox <br...@reply.infinity.nu> wrote:
> Try to be careful with the reformatting. Lots of diffs there for one line change.
Sorry.
I normally check my changes line by line before committing.
To avoid this issue and to remind me what changes so I can write a
decent commit message.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: svn commit: r708143 - /maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java
Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
Try to be careful with the reformatting. Lots of diffs there for one line change.
-----Original Message-----
From: baerrach@apache.org [mailto:baerrach@apache.org]
Sent: Monday, October 27, 2008 7:37 AM
To: commits@maven.apache.org
Subject: svn commit: r708143 - /maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java
Author: baerrach
Date: Mon Oct 27 04:37:13 2008
New Revision: 708143
URL: http://svn.apache.org/viewvc?rev=708143&view=rev
Log:
minor printing cleanup lowercased "includes"
fixed javadoc to avoid usage of \/ to instead encode forward slash via HTML character entity reference /
Modified:
maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java
Modified: maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java?rev=708143&r1=708142&r2=708143&view=diff
==============================================================================
--- maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java (original)
+++ maven/plugins/trunk/maven-dependency-plugin/src/main/java/org/apache/maven/plugin/dependency/AbstractDependencyMojo.java Mon Oct 27 04:37:13 2008
@@ -1,6 +1,6 @@
package org.apache.maven.plugin.dependency;
-/*
+/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@@ -16,7 +16,7 @@
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
- * under the License.
+ * under the License.
*/
import java.io.File;
@@ -49,7 +49,7 @@
{
/**
* Used to look up Artifacts in the remote repository.
- *
+ *
* @parameter expression="${component.org.apache.maven.artifact.factory.ArtifactFactory}"
* @required
* @readonly
@@ -58,7 +58,7 @@
/**
* Used to look up Artifacts in the remote repository.
- *
+ *
* @parameter expression="${component.org.apache.maven.artifact.resolver.ArtifactResolver}"
* @required
* @readonly
@@ -67,7 +67,7 @@
/**
* Artifact collector, needed to resolve dependencies.
- *
+ *
* @component role="org.apache.maven.artifact.resolver.ArtifactCollector"
* @required
* @readonly
@@ -84,7 +84,7 @@
/**
* Location of the local repository.
- *
+ *
* @parameter expression="${localRepository}"
* @readonly
* @required
@@ -93,7 +93,7 @@
/**
* List of Remote Repositories used by the resolver
- *
+ *
* @parameter expression="${project.remoteArtifactRepositories}"
* @readonly
* @required
@@ -102,7 +102,7 @@
/**
* To look up Archiver/UnArchiver implementations
- *
+ *
* @parameter expression="${component.org.codehaus.plexus.archiver.manager.ArchiverManager}"
* @required
* @readonly
@@ -111,7 +111,7 @@
/**
* POM
- *
+ *
* @parameter expression="${project}"
* @readonly
* @required
@@ -120,7 +120,7 @@
/**
* Contains the full list of projects in the reactor.
- *
+ *
* @parameter expression="${reactorProjects}"
* @required
* @readonly
@@ -129,7 +129,7 @@
/**
* If the plugin should be silent.
- *
+ *
* @optional
* @since 2.0
* @parameter expression="${silent}"
@@ -139,7 +139,7 @@
/**
* Output absolute filename for resolved artifacts
- *
+ *
* @optional
* @since 2.0
* @parameter expression="${outputAbsoluteArtifactFilename}"
@@ -176,10 +176,10 @@
/**
* Does the actual copy of the file and logging.
- *
+ *
* @param artifact represents the file to copy.
* @param destFile file name of destination file.
- *
+ *
* @throws MojoExecutionException with a message if an
* error occurs.
*/
@@ -209,16 +209,16 @@
/**
* Unpacks the archive file.
- *
+ *
* @param file File to be unpacked.
* @param location Location where to put the unpacked
* files.
* @param includes Comma separated list of file patterns
- * to include i.e. **\/*.xml,
- * **\/*.properties
+ * to include i.e. **/.xml,
+ * **/*.properties
* @param excludes Comma separated list of file patterns
- * to exclude i.e. **\/*.xml,
- * **\/*.properties
+ * to exclude i.e. **/*.xml,
+ * **/*.properties
*/
protected void unpack ( File file, File location, String includes, String excludes )
throws MojoExecutionException
@@ -227,7 +227,7 @@
{
getLog().info(
"Unpacking " + file.getPath() + " to\n " + location.getPath()
- + "\n with Includes " + includes + " and excludes:" + excludes );
+ + "\n with includes " + includes + " and excludes:" + excludes );
location.mkdirs();