[GitHub] [helix] narendly commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #451: Validate the instance capacity/partition weight configuration while constructing the assignable instances
URL: https://github.com/apache/helix/pull/451#discussion_r321443541
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableReplica.java
 ##########
 @@ -96,4 +101,29 @@ public void testConstructRepliaWithResourceConfig() throws IOException {
     Assert.assertEquals(replica.getResourceInstanceGroupTag(), group);
     Assert.assertEquals(replica.getResourceMaxPartitionsPerInstance(), maxPartition);
   }
+
+  @Test
+  public void testIncompletePartitionWeightConfig() throws IOException {
 
 Review comment:
   Question:
   
   If we don't have the key, are we treating it as 0 or erroring out?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org