You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/31 14:28:05 UTC

[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #455: [YUNIKORN-1301] Enable state-aware app sorting e2e test

craigcondit opened a new pull request, #455:
URL: https://github.com/apache/yunikorn-k8shim/pull/455

   ### What is this PR for?
   Enable dormant state-aware app sorting test for E2E.
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [x] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1301
   
   ### How should this be tested?
   Enabled e2e test.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-k8shim] craigcondit closed pull request #455: [YUNIKORN-1301] Enable state-aware app sorting e2e test

Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #455: [YUNIKORN-1301] Enable state-aware app sorting e2e test
URL: https://github.com/apache/yunikorn-k8shim/pull/455


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #455: [YUNIKORN-1301] Enable state-aware app sorting e2e test

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #455:
URL: https://github.com/apache/yunikorn-k8shim/pull/455#issuecomment-1233031531

   # [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/455?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#455](https://codecov.io/gh/apache/yunikorn-k8shim/pull/455?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8278178) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/824351f0b2c345fddca122a6c3f6ad69353facb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (824351f) will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #455      +/-   ##
   ==========================================
   - Coverage   67.00%   66.97%   -0.03%     
   ==========================================
     Files          41       41              
     Lines        6767     6767              
   ==========================================
   - Hits         4534     4532       -2     
   - Misses       2062     2064       +2     
     Partials      171      171              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/455/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org