You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/13 08:28:00 UTC
[GitHub] [iceberg] jun-he opened a new pull request #2083: Fix the partition field id when appending a field to the V2 spec.
jun-he opened a new pull request #2083:
URL: https://github.com/apache/iceberg/pull/2083
The field ID in the new spec should start with the largest last assigned partition id among all table specs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2083: Fix the partition field id when appending a field to the V2 spec.
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2083:
URL: https://github.com/apache/iceberg/pull/2083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2083: Fix the partition field id when appending a field to the V2 spec.
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2083:
URL: https://github.com/apache/iceberg/pull/2083#issuecomment-759775342
Good catch. We also still need to add a `lastAssignedFieldId` to table metadata for this, like we have for last assigned column ID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] yyanyy commented on pull request #2083: Fix the partition field id when appending a field to the V2 spec.
Posted by GitBox <gi...@apache.org>.
yyanyy commented on pull request #2083:
URL: https://github.com/apache/iceberg/pull/2083#issuecomment-759833051
> Good catch. We also still need to add a `lastAssignedFieldId` to table metadata for this, like we have for last assigned column ID.
Is this just to ensure implementation correctness per spec? As it seems that from the current implementation getting this from `PartitionSpec::lastAssignedFieldId` should be good enough, as there's no table operation to actually remove a partition field from specs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org