You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/04 08:14:12 UTC
[jira] [Commented] (DRILL-4654) Expose New System Metrics

    [ https://issues.apache.org/jira/browse/DRILL-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270172#comment-15270172 ] 

ASF GitHub Bot commented on DRILL-4654:
---------------------------------------

GitHub user sudheeshkatkam opened a pull request:

    https://github.com/apache/drill/pull/495

    DRILL-4654: Add new metrics to the MetricRegistry

    + New metrics: running queries, pending queries, completed queries,
      used memory (root allocator)
    + Borrow SystemPropertyUtil class from Netty
    + Configure DrillMetrics params through system properties
    + Deprecate getMetrics method in contextual objects
    + Rename "current" to "used" for RPC allocator current memory usage to
      follow convention

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudheeshkatkam/drill DRILL-4654

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/495.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #495
    
----
commit 1fc205bebaf3c1f20df85996ba49cf98b60e4c9e
Author: Sudheesh Katkam <sk...@maprtech.com>
Date:   2016-05-04T06:10:47Z

    DRILL-4654: Add new metrics to the MetricRegistry
    
    + New metrics: running queries, pending queries, completed queries,
      used memory (root allocator)
    + Borrow SystemPropertyUtil class from Netty
    + Configure DrillMetrics params through system properties
    + Deprecate getMetrics method in contextual objects
    + Rename "current" to "used" for RPC allocator current memory usage to
      follow convention

----


> Expose New System Metrics
> -------------------------
>
>                 Key: DRILL-4654
>                 URL: https://issues.apache.org/jira/browse/DRILL-4654
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Sudheesh Katkam
>            Assignee: Sudheesh Katkam
>             Fix For: 1.8.0
>
>
> + Add more metrics to the DrillMetrics registry (exposed through web UI and jconsole, through JMX): pending queries, running queries, completed queries, current memory usage (root allocator)
> + Clean up and document metric registration API
> + Deprecate getMetrics() method in contextual objects; use DrillMetrics.getRegistry() directly
> + Make JMX reporting and log reporting configurable through system properties (since config file is not meant to be used in common module)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)