You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2020/11/27 02:03:48 UTC
[GitHub] [james-project] chibenwa opened a new pull request #267: JAMES-3056 Disable read repairs during consistency tests
chibenwa opened a new pull request #267:
URL: https://github.com/apache/james-project/pull/267
Usual suspect...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #267: JAMES-3056 Disable read repairs during consistency tests
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #267:
URL: https://github.com/apache/james-project/pull/267#issuecomment-734782525
Merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #267: JAMES-3056 Disable read repairs during consistency tests
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #267:
URL: https://github.com/apache/james-project/pull/267#discussion_r531492385
##########
File path: mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/CassandraMailboxManagerConsistencyTest.java
##########
@@ -417,7 +422,7 @@ void deleteMailboxByIdShouldBeConsistentWhenMailboxDaoFails(CassandraCluster cas
}));
}
- @Test
+ @RepeatedTest(100)
Review comment:
No that's a mistake
##########
File path: mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/CassandraMailboxManagerConsistencyTest.java
##########
@@ -417,7 +422,7 @@ void deleteMailboxByIdShouldBeConsistentWhenMailboxDaoFails(CassandraCluster cas
}));
}
- @Test
+ @RepeatedTest(100)
Review comment:
Yes that's a mistake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #267: JAMES-3056 Disable read repairs during consistency tests
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #267:
URL: https://github.com/apache/james-project/pull/267#discussion_r531467574
##########
File path: mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/CassandraMailboxManagerConsistencyTest.java
##########
@@ -417,7 +422,7 @@ void deleteMailboxByIdShouldBeConsistentWhenMailboxDaoFails(CassandraCluster cas
}));
}
- @Test
+ @RepeatedTest(100)
Review comment:
isn't this a leftover of diagnosing the issue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa closed pull request #267: JAMES-3056 Disable read repairs during consistency tests
Posted by GitBox <gi...@apache.org>.
chibenwa closed pull request #267:
URL: https://github.com/apache/james-project/pull/267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org