You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Tuure Laurinolli (JIRA)" <ji...@apache.org> on 2008/09/05 16:01:44 UTC

[jira] Created: (DIRMINA-620) IoSession ha superfluous close() methods

IoSession ha superfluous close() methods
----------------------------------------

                 Key: DIRMINA-620
                 URL: https://issues.apache.org/jira/browse/DIRMINA-620
             Project: MINA
          Issue Type: Improvement
          Components: Core
    Affects Versions: 2.0.0-M3, 2.0.0-M2, 2.0.0-M1
            Reporter: Tuure Laurinolli
            Priority: Minor
             Fix For: 2.0.0-M4


IoSession has three methods for closing the session: close() which closes immediately, closeOnFlush(), which closes after last queued write is complete and close(boolean) which can be set to do either.

The two first variants should be removed and close(boolean) retained to make the API cleaner. Also, having a single close(boolean) method forces the user to think about the issue of closing immediately versus closing after last queued write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRMINA-620) IoSession has superfluous close() methods

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Vermillard resolved DIRMINA-620.
---------------------------------------

    Resolution: Fixed

> IoSession has superfluous close() methods
> -----------------------------------------
>
>                 Key: DIRMINA-620
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-620
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3
>            Reporter: Tuure Laurinolli
>            Priority: Minor
>             Fix For: 2.0.0-M4
>
>
> IoSession has three methods for closing the session: close() which closes immediately, closeOnFlush(), which closes after last queued write is complete and close(boolean) which can be set to do either.
> The two first variants should be removed and close(boolean) retained to make the API cleaner. Also, having a single close(boolean) method forces the user to think about the issue of closing immediately versus closing after last queued write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRMINA-620) IoSession has superfluous close() methods

Posted by "Tuure Laurinolli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tuure Laurinolli updated DIRMINA-620:
-------------------------------------

    Summary: IoSession has superfluous close() methods  (was: IoSession ha superfluous close() methods)

Fixed typo in summary.

> IoSession has superfluous close() methods
> -----------------------------------------
>
>                 Key: DIRMINA-620
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-620
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3
>            Reporter: Tuure Laurinolli
>            Priority: Minor
>             Fix For: 2.0.0-M4
>
>
> IoSession has three methods for closing the session: close() which closes immediately, closeOnFlush(), which closes after last queued write is complete and close(boolean) which can be set to do either.
> The two first variants should be removed and close(boolean) retained to make the API cleaner. Also, having a single close(boolean) method forces the user to think about the issue of closing immediately versus closing after last queued write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRMINA-620) IoSession has superfluous close() methods

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRMINA-620.
-------------------------------------


> IoSession has superfluous close() methods
> -----------------------------------------
>
>                 Key: DIRMINA-620
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-620
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3
>            Reporter: Tuure Laurinolli
>            Priority: Minor
>             Fix For: 2.0.0-M4
>
>
> IoSession has three methods for closing the session: close() which closes immediately, closeOnFlush(), which closes after last queued write is complete and close(boolean) which can be set to do either.
> The two first variants should be removed and close(boolean) retained to make the API cleaner. Also, having a single close(boolean) method forces the user to think about the issue of closing immediately versus closing after last queued write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.