You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/05/19 13:18:51 UTC

[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1279: StableMarriage Functions

Shafaq-Siddiqi commented on pull request #1279:
URL: https://github.com/apache/systemds/pull/1279#issuecomment-844098690


   LGTM, 
   Thank you @atefeh-asayesh  for your contribution. During the merge, I did the following changes,
   Fixed the formatting (in DML we follow two-space indentation)
   Renamed the function from stablemarriageA to stableMarriage to follow the camel-case naming convention.
   I have also added few single-node and spark tests to the test file.
   I have removed the unnecessary environment specific config files from the commit (setting .gitignore will help you to exclude those files from your commits) 
   I have changed the author of the commit from Saeed to your name. Please fix it in your IDE/Git settings to avoid this issue in the future.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org