You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Andrew Grieve (JIRA)" <ji...@apache.org> on 2015/01/16 15:57:34 UTC
[jira] [Commented] (CB-8319) Plugman is exposing private module
"config_changes" in its interface
[ https://issues.apache.org/jira/browse/CB-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280332#comment-14280332 ]
Andrew Grieve commented on CB-8319:
-----------------------------------
Looked through github for usages, and found only copies of cordova-lib / plugman:
https://github.com/search?p=5&q=plugman.config_changes&type=Code&utf8=%E2%9C%93
> Plugman is exposing private module "config_changes" in its interface
> --------------------------------------------------------------------
>
> Key: CB-8319
> URL: https://issues.apache.org/jira/browse/CB-8319
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Reporter: Andrew Grieve
> Assignee: Andrew Grieve
> Priority: Minor
>
> config_changes is basically the guts of the prepare function. Looks like probably it was exposed so that CLI could access it in its prepare method.
> https://github.com/apache/cordova-lib/blob/850f4502a9a283/cordova-lib/src/cordova/prepare.js#L105
> Now that cordova-lib has both of them, we really should not be exposing it, since it's not likely to be a stable API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org