You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2025/06/25 11:27:51 UTC

[PR] Fix end of files; files should end with one newline [myfaces]

jbampton opened a new pull request, #914:
URL: https://github.com/apache/myfaces/pull/914

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix end of files; files should end with one newline [myfaces]

Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton closed pull request #914: Fix end of files; files should end with one newline
URL: https://github.com/apache/myfaces/pull/914


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix end of files; files should end with one newline [myfaces]

Posted by "bohmber (via GitHub)" <gi...@apache.org>.
bohmber commented on PR #914:
URL: https://github.com/apache/myfaces/pull/914#issuecomment-3047480573

   @jbampton did you test the result?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix end of files; files should end with one newline [myfaces]

Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #914:
URL: https://github.com/apache/myfaces/pull/914#issuecomment-3209528019

   and why is this required?
   when the next user commits something different, its still missaligned
   
   and TBH i dont like to accept such mass PRs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix end of files; files should end with one newline [myfaces]

Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #914:
URL: https://github.com/apache/myfaces/pull/914#issuecomment-3249175426

   > and why is this required? when the next user commits something different, its still missaligned
   > 
   > and TBH i dont like to accept such mass PRs
   
   It is standard practice to end files with a newline.  We can add a pre-commit hook that enforces this rule just like other top ASF projects. 
   
   So I have been waiting 2 months for #917 to be reviewed.
   
   @tandraschko that is fine.  I will close this PR and move on to another project. Thanks
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org