[GitHub] zentol commented on a change in pull request #6409: [FLINK-9899][Kinesis Connector] Add comprehensive per-shard metrics to ShardConsumer

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #6409: [FLINK-9899][Kinesis Connector] Add comprehensive per-shard metrics to ShardConsumer
URL: https://github.com/apache/flink/pull/6409#discussion_r207484326
 
 

 ##########
 File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/metrics/ShardMetricsReporter.java
 ##########
 @@ -28,14 +28,14 @@
 public class ShardMetricsReporter {
 
 	private volatile long millisBehindLatest = -1;
-	private volatile double loopFrequencyHz = 0.0;
-	private volatile double bytesPerRead = 0.0;
-	private volatile long runLoopTimeNanos = 0L;
-	private volatile long averageRecordSizeBytes = 0L;
-	private volatile long sleepTimeMillis = 0L;
-	private volatile int numberOfAggregatedRecords = 0;
-	private volatile int numberOfDeaggregatedRecords = 0;
-	private volatile int maxNumberOfRecordsPerFetch = 0;
+	private volatile double loopFrequencyHz = -1.0;
+	private volatile double bytesPerRead = -1.0;
+	private volatile long runLoopTimeNanos = -1;
+	private volatile long averageRecordSizeBytes = -1;
+	private volatile long sleepTimeMillis = -1;
 
 Review comment:
   negative default values are discouraged as they can mess with aggregations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services