[jira] [Commented] (HBASE-14766) WALEntryFilter's filter implement, cell.getFamily() needs to be replaced with the new low-cost implementation.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991012#comment-14991012 ] 

Hadoop QA commented on HBASE-14766:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12770731/HBASE-14766-v001.patch
  against master branch at commit 21b607e322df0404c9941bc3dd12faef6b7957fe.
  ATTACHMENT ID: 12770731

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16397//console

This message is automatically generated.

> WALEntryFilter's filter implement, cell.getFamily() needs to be replaced with the new low-cost implementation.
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14766
>                 URL: https://issues.apache.org/jira/browse/HBASE-14766
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>         Attachments: HBASE-14766-v001.patch
>
>
> Cell's getFamily() gets an array copy of the cell's family, while in the filter function,  it just needs to peek into the family and do a compare. 
> Replace 
> Bytes.toString(cell.getFamily())
> with 
> Bytes.toString(cell.getFamilyArray(), cell.getFamilyOffset(), cell.getFamilyLength())



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)