You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/03/07 07:23:43 UTC

[Impala-ASF-CR](2.x) IMPALA-6883: [DOCS] Refactor impala authorization doc 

Hello Alex Rodoni, Impala Public Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12688

to review the following change.


Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc
......................................................................

IMPALA-6883: [DOCS] Refactor impala_authorization doc

Change-Id: I3df72adb25dcdcbc286934b048645f47d876b33d
Reviewed-on: http://gerrit.cloudera.org:8080/10786
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
4 files changed, 565 insertions(+), 614 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/12688/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3df72adb25dcdcbc286934b048645f47d876b33d
Gerrit-Change-Number: 12688
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR](2.x) IMPALA-6883: [DOCS] Refactor impala authorization doc

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12688 )

Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3df72adb25dcdcbc286934b048645f47d876b33d
Gerrit-Change-Number: 12688
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 15:44:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6883: [DOCS] Refactor impala authorization doc

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12688 )

Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc
......................................................................


Patch Set 1:

Conflicts:
        docs/topics/impala_grant.xml

I try to resolve the conflicts as reasonable as possible. Feel like we need to go through all the docs about fine-grained privileges when we release 2.13.


-- 
To view, visit http://gerrit.cloudera.org:8080/12688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3df72adb25dcdcbc286934b048645f47d876b33d
Gerrit-Change-Number: 12688
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 07:39:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6883: [DOCS] Refactor impala authorization doc

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12688 )

Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/249/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3df72adb25dcdcbc286934b048645f47d876b33d
Gerrit-Change-Number: 12688
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 07:29:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6883: [DOCS] Refactor impala authorization doc

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12688 )

Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/249/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3df72adb25dcdcbc286934b048645f47d876b33d
Gerrit-Change-Number: 12688
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 07:23:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6883: [DOCS] Refactor impala authorization doc

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12688 )

Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc
......................................................................

IMPALA-6883: [DOCS] Refactor impala_authorization doc

Change-Id: I3df72adb25dcdcbc286934b048645f47d876b33d
Reviewed-on: http://gerrit.cloudera.org:8080/10786
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12688
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
4 files changed, 565 insertions(+), 614 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Fredy Wijaya: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I3df72adb25dcdcbc286934b048645f47d876b33d
Gerrit-Change-Number: 12688
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>