[GitHub] [arrow-julia] svilupp opened a new issue, #392: Typo in kwargs of arrowvector for ListKind

["svilupp (via GitHub)" <gi...@apache.org>]

svilupp opened a new issue, #392:
URL: https://github.com/apache/arrow-julia/issues/392

   I believe I've noticed a typo in [passing kwargs of arrowvector](https://github.com/apache/arrow-julia/blob/63d2c9d3ca4539a0ea831ae8ecafa71b051d475d/src/arraytypes/list.jl#L198).
   
   For the special case when the ToList struct eltype isn't strict, we call:
   `data = arrowvector(flat, i, nl + 1, fi, de, ded, nothing; lareglists=largelists, kw...)`
   I believe it should be:
   `data = arrowvector(flat, i, nl + 1, fi, de, ded, nothing; largelists=largelists, kw...)`
   There is no kwarg `lareglists`.
   
   It doesn't throw any errors, because mistyped kwarg is just passed around within `kw...`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] quinnj closed issue #392: Typo in kwargs of arrowvector for ListKind

["quinnj (via GitHub)" <gi...@apache.org>]

quinnj closed issue #392: Typo in kwargs of arrowvector for ListKind
URL: https://github.com/apache/arrow-julia/issues/392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] quinnj commented on issue #392: Typo in kwargs of arrowvector for ListKind

["quinnj (via GitHub)" <gi...@apache.org>]

quinnj commented on issue #392:
URL: https://github.com/apache/arrow-julia/issues/392#issuecomment-1588480884

   Fix is up; thanks for catching this: https://github.com/apache/arrow-julia/pull/467. It's not a largely used feature because it's a testing feature to force to use a larger integer type for list offsets instead of the default smaller when tables have reasonable # of elements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org