You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by 大诗胸 <so...@gmail.com> on 2017/04/01 07:57:36 UTC
Re: Q; How to deal with Invalid Pull Requests on GitHub?
Seems not working in https://github.com/apache/incubator-weex/pull/141
Am I commit to the wrong branch?
On Sat, Apr 1, 2017 at 12:00 AM, Niclas Hedhman <ni...@hedhman.org> wrote:
> Thank you all on infra@.... Always a pleasure to see how helpful you are.
>
> Cheers
> Niclas
>
> On Fri, Mar 31, 2017 at 10:11 PM, Pono Takamori <po...@apache.org> wrote:
>
> > If you have a batch of them to close, feel free to create a ticket on
> > JIRA with the PR number and we can close them for you :)
> >
> > On Fri, Mar 31, 2017 at 2:26 AM, Dominik Stadler <dominik.stadler@gmx.at
> >
> > wrote:
> > > one workaround that I use is to do a dummy-commit with a "closes"
> > comment,
> > > not nice, but works.
> > >
> > > Dominik
> > >
> > > On Mar 31, 2017 10:20, "Niclas Hedhman" <ni...@hedhman.org> wrote:
> > >>
> > >> Hi,
> > >> Some pull requests are invalid for one reason or the other, and the
> > >> original creator is "missing" or don't want to remove it, how should
> we
> > get
> > >> it taken away?
> > >>
> > >>
> > >> Thanks
> > >> --
> > >> Niclas Hedhman, Software Developer
> > >> http://polygene.apache.org - New Energy for Java
> >
>
>
>
> --
> Niclas Hedhman, Software Developer
> http://polygene.apache.org - New Energy for Java
>
--
sospartan
Phone:13588488290
HangZhou
Re: Q; How to deal with Invalid Pull Requests on GitHub?
Posted by sospartan <so...@gmail.com>.
It's working.
Thanks.
On Sun, Apr 2, 2017 at 12:57 AM, Geoffrey Corey <co...@apache.org> wrote:
> Unfortunately you have send these commits to the default branch (default
> branch from GitHub's view)
>
> On Sat, Apr 1, 2017 at 12:58 AM 大诗胸 <so...@gmail.com> wrote:
>
>> Seems not working in https://github.com/apache/incubator-weex/pull/141
>> Am I commit to the wrong branch?
>>
>> On Sat, Apr 1, 2017 at 12:00 AM, Niclas Hedhman <ni...@hedhman.org>
>> wrote:
>>
>> Thank you all on infra@.... Always a pleasure to see how helpful you are.
>>
>> Cheers
>> Niclas
>>
>> On Fri, Mar 31, 2017 at 10:11 PM, Pono Takamori <po...@apache.org> wrote:
>>
>> > If you have a batch of them to close, feel free to create a ticket on
>> > JIRA with the PR number and we can close them for you :)
>> >
>> > On Fri, Mar 31, 2017 at 2:26 AM, Dominik Stadler <
>> dominik.stadler@gmx.at>
>> > wrote:
>> > > one workaround that I use is to do a dummy-commit with a "closes"
>> > comment,
>> > > not nice, but works.
>> > >
>> > > Dominik
>> > >
>> > > On Mar 31, 2017 10:20, "Niclas Hedhman" <ni...@hedhman.org> wrote:
>> > >>
>> > >> Hi,
>> > >> Some pull requests are invalid for one reason or the other, and the
>> > >> original creator is "missing" or don't want to remove it, how should
>> we
>> > get
>> > >> it taken away?
>> > >>
>> > >>
>> > >> Thanks
>> > >> --
>> > >> Niclas Hedhman, Software Developer
>> > >> http://polygene.apache.org - New Energy for Java
>> >
>>
>>
>>
>> --
>> Niclas Hedhman, Software Developer
>> http://polygene.apache.org - New Energy for Java
>>
>>
>>
>>
>> --
>> sospartan
>> Phone:13588488290
>> HangZhou
>>
>
--
sospartan
Phone:13588488290
HangZhou
Re: Q; How to deal with Invalid Pull Requests on GitHub?
Posted by Geoffrey Corey <co...@apache.org>.
Unfortunately you have send these commits to the default branch (default
branch from GitHub's view)
On Sat, Apr 1, 2017 at 12:58 AM 大诗胸 <so...@gmail.com> wrote:
> Seems not working in https://github.com/apache/incubator-weex/pull/141
> Am I commit to the wrong branch?
>
> On Sat, Apr 1, 2017 at 12:00 AM, Niclas Hedhman <ni...@hedhman.org>
> wrote:
>
> Thank you all on infra@.... Always a pleasure to see how helpful you are.
>
> Cheers
> Niclas
>
> On Fri, Mar 31, 2017 at 10:11 PM, Pono Takamori <po...@apache.org> wrote:
>
> > If you have a batch of them to close, feel free to create a ticket on
> > JIRA with the PR number and we can close them for you :)
> >
> > On Fri, Mar 31, 2017 at 2:26 AM, Dominik Stadler <dominik.stadler@gmx.at
> >
> > wrote:
> > > one workaround that I use is to do a dummy-commit with a "closes"
> > comment,
> > > not nice, but works.
> > >
> > > Dominik
> > >
> > > On Mar 31, 2017 10:20, "Niclas Hedhman" <ni...@hedhman.org> wrote:
> > >>
> > >> Hi,
> > >> Some pull requests are invalid for one reason or the other, and the
> > >> original creator is "missing" or don't want to remove it, how should
> we
> > get
> > >> it taken away?
> > >>
> > >>
> > >> Thanks
> > >> --
> > >> Niclas Hedhman, Software Developer
> > >> http://polygene.apache.org - New Energy for Java
> >
>
>
>
> --
> Niclas Hedhman, Software Developer
> http://polygene.apache.org - New Energy for Java
>
>
>
>
> --
> sospartan
> Phone:13588488290
> HangZhou
>