[GitHub] [lucene] jpountz commented on a diff in pull request #1021: LUCENE-10603: Remove SSDV#NO_MORE_ORDS definition

[GitBox <gi...@apache.org>]

jpountz commented on code in PR #1021:
URL: https://github.com/apache/lucene/pull/1021#discussion_r920549702


##########
lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java:
##########
@@ -1055,12 +1051,9 @@ public long cost() {
     @Override
     public long nextOrd() throws IOException {
       assertThread("Sorted set doc values", creationThread);
-      assert lastOrd != NO_MORE_ORDS;
       assert exists;
       long ord = in.nextOrd();
       assert ord < valueCount;
-      assert ord == NO_MORE_ORDS || ord > lastOrd;
-      lastOrd = ord;
       return ord;

Review Comment:
   Maybe we could also verify here that the caller is not calling `nextOrd` more than `count` times?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org