Re: [E] TS API Review: New HTTP/2 stream id and priority getters

[Walt Karas <wk...@verizonmedia.com.INVALID>]

Would traffic replay use this information?  More generally, what I'm
wondering is, how does traffic dump coordinate with TS's logging capability?

I think typically, the TS API provides these sorts of handles to plugins so
they can change the processing of the transaction/session/etc.  We could
also consider adding an API function that would return log fields in the
TXN_CLOSE hook.

On Fri, Aug 28, 2020 at 9:43 AM Brian Neradt <br...@gmail.com> wrote:

> Hi dev@trafficserver.apache.org,
>
> It would be helpful to add HTTP/2 stream and priority support to Traffic
> Dump. In order for the plugin to access this information, I propose adding
> the following two functions to the TS API:
>
> tsapi TSReturnCode TSHttpTxnClientHttp2StreamIdGet(TSHttpTxn txnp, uint32_t
> *stream_id);
>
> tsapi TSReturnCode TSHttpTxnClientHttp2PriorityGet(TSHttpTxn txnp, int
> *stream_dependency, int *weight);
>
> I've created a draft PR with this implemented along with Traffic Dump's use
> of it:
>
> https://urldefense.com/v3/__https://github.com/apache/trafficserver/pull/7149__;!!Op6eflyXZCqGR5I!VE1M67o_6YLQnYxkTvZVSCMAX1AnvdGwQ3lVwnMPiI2JXik1jP4KBcS2jg7KmrcJbg$
>
> Please let me know if there are any concerns or suggestions for improvement
> concerning this.
>
> Thanks!
> Brian
>
> --
> "Come to Me, all who are weary and heavy-laden, and I will
> give you rest. Take My yoke upon you and learn from Me, for
> I am gentle and humble in heart, and you will find rest for
> your souls. For My yoke is easy and My burden is light."
>
>     ~ Matthew 11:28-30
>