[GitHub] [curator] bigmarvin opened a new pull request #355: [CURATOR-464] attach orignal artifacts with classifier original

[GitBox <gi...@apache.org>]

bigmarvin opened a new pull request #355: [CURATOR-464] attach orignal artifacts with classifier original
URL: https://github.com/apache/curator/pull/355
 
 
   Would like to revisit the following issue.
   
   https://issues.apache.org/jira/browse/CURATOR-464
   
   The current approach would be preventing shaded artifacts from replacing original artifacts. Instead, shaded artifacts are now also attached with classifier uber, next to original artifacts, so clients could integrate either based on their need.
   
   This approach is my preference while it'll be a little expensive in adoption, as new classifier must be added during upgrade. If this really bothers, here are 2 alternatives we may go:
   
   1. **Removing the reloaction in shading.** Packages like `org.apache.curator.shaded.com.google` could be found nowhere but in curator-client, which doesn't export these relocated packages in its manifest. Without relocation, these packages could be fulfilled by some other bundle, following the import instruction inside the manifest. However, if shaded classes take priority, problems would be expected in OSGi runtime because same classes are loaded by different bundles and they become different classses. This decision belongs to the implementation of OSGi runtime.
   
   2. **Attaching original artifact with some classifier like 'slim'.** This is essentially the reverse way of the proposed approach, which costs little in adoption as no new classifier is required during upgrade. Personally, I don't like this way as we don't usually put classifier on original artifacts. However, if compared with this issue not being fixed, this alternative would be better.
   
   Please review the change and any comment is welcome.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services