[jira] Commented: (OPENJPA-266) Add Extensibility: Change "private" field/method to "protected" or "public" in OpenJPA classes to be extendable

["Michael Dick (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514987 ] 

Michael Dick commented on OPENJPA-266:
--------------------------------------

The last change regarding DBDictionaries looks like it's a good start, but I have a few questions / issues.

The changes seem to be intended to enable other vendors to repackage OpenJPA with their own set of DBDictionaries. This is a good thing, but the code only allows DB2, Oracle and SQLServer to be extended. This should be expanded and generalized to allow any DBDictionary to be overridden.

The fix also requires the user to get a configuration object and cast it to our implementation class. This should be changed to use the JDBCConfiguration interface. 

If this is intended for use by other vendors, why don't we just provide the ability for the DBDictionaryFactory class to be extended? If the DBDictionaryFactory class was configurable (like SQLFactory for example), then vendors could prefer their own set of classes without messing around with JDBCConfigurationImpl. 



> Add Extensibility: Change "private" field/method to "protected" or "public"  in OpenJPA classes to be extendable
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: OPENJPA-266
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-266
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 1.0.0
>            Reporter: Catalina Wei
>            Priority: Trivial
>             Fix For: 1.0.0
>
>         Attachments: OpenJPA-266.patch, OPENJPA-266.patch.txt
>
>
> In order to extend existing OpenJPA classes,  for example OperationOrderUpdateManager, private field or method needed to change to protected or public.
> This kind of modification is not adding any functionality but making OpenJPA classes subclassable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.