[GitHub] [beam] boyuanzz commented on a change in pull request #11492: [BEAM-9801] Pass in fire timestamp to timer callback

[GitBox <gi...@apache.org>]

boyuanzz commented on a change in pull request #11492:
URL: https://github.com/apache/beam/pull/11492#discussion_r413175330



##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -229,7 +229,7 @@ def invoke_timer_callback(self, user_state_context, key, window, timestamp):
         kwargs[kw] = user_state_context.get_state(state_spec, key, window)
       for kw, timer_spec in self.timer_args_to_replace.items():
         kwargs[kw] = user_state_context.get_timer(
-            timer_spec, key, window, None, None)
+            timer_spec, key, window, timestamp, None)

Review comment:
       The paneinfo should also be passed in here. You can get paneinfo from `timer.paneinfo`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org