You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by MikeThomsen <gi...@git.apache.org> on 2018/04/11 12:29:59 UTC

[GitHub] nifi pull request #2572: NIFI-4952 Add EL support for JettyWebSocketClient a...

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2572#discussion_r180735170
  
    --- Diff: nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketClient.java ---
    @@ -142,10 +142,10 @@ public void startClient(final ConfigurationContext context) throws Exception{
             client.start();
             activeSessions.clear();
     
    -        webSocketUri = new URI(context.getProperty(WS_URI).getValue());
    -        connectionTimeoutMillis = context.getProperty(CONNECTION_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS);
    +        webSocketUri = new URI(context.getProperty(WS_URI).evaluateAttributeExpressions().getValue());
    --- End diff --
    
    It looks like you're still using `expressionLanguageSupported(boolean)` in this PR. Please rebase off of the latest master and add change it `expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)`.


---