You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2015/12/13 16:28:29 UTC
Re: Review Request 37168: MESOS-3063 (Add an example framework using
dynamic reservation)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
-----------------------------------------------------------
(Updated Dec. 13, 2015, 11:28 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase the code; @mcypark, please help to review when you have time.
Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063
Repository: mesos
Description
-------
Provide example for dynamic reservation features.
Diffs (updated)
-----
src/Makefile.am 9762f85
src/examples/dynamic_reservation_framework.cpp PRE-CREATION
src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
src/tests/examples_tests.cpp 5211f54
Diff: https://reviews.apache.org/r/37168/diff/
Testing
-------
make
make check
Thanks,
Klaus Ma
Re: Review Request 37168: Add an example framework using dynamic
reservation.
Posted by Klaus Ma <kl...@gmail.com>.
> On Feb. 23, 2016, 7:23 a.m., Joerg Schad wrote:
> > src/tests/dynamic_reservation_framework_test.sh, line 30
> > <https://reviews.apache.org/r/37168/diff/9/?file=1263708#file1263708line30>
> >
> > Thy do we need this? Comparing to persistent_volume_framework_test.sh
After implicit role, it's unnecessary; removed. But before implicit role, it's required for master to accept more role; it's a litte different with persistent_volume_framework test: persistent_volume_frameowork_test uses test as default role, and considered it as reserved, but we can not dynamical reserve resources on default role.
> On Feb. 23, 2016, 7:23 a.m., Joerg Schad wrote:
> > src/examples/dynamic_reservation_framework.cpp, line 217
> > <https://reviews.apache.org/r/37168/diff/9/?file=1263707#file1263707line217>
> >
> > LOG(ERROR) << message; or at least add output indicating this is an error.
Add "Error: " to indicate it's an error.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review120212
-----------------------------------------------------------
On March 7, 2016, 5:20 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 5:20 p.m.)
>
>
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
>
>
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide example for dynamic reservation features.
>
>
> Diffs
> -----
>
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/examples/dynamic_reservation_framework.cpp PRE-CREATION
> src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
> src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695
>
> Diff: https://reviews.apache.org/r/37168/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 37168: Added example for dynamic reservation
features.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review120212
-----------------------------------------------------------
src/examples/dynamic_reservation_framework.cpp (line 94)
<https://reviews.apache.org/r/37168/#comment181640>
Does it make sense to add a comment somewhere explaing the different states and transitions between them?
src/examples/dynamic_reservation_framework.cpp (line 217)
<https://reviews.apache.org/r/37168/#comment181639>
LOG(ERROR) << message; or at least add output indicating this is an error.
src/tests/dynamic_reservation_framework_test.sh (line 28)
<https://reviews.apache.org/r/37168/#comment181638>
Thy do we need this? Comparing to persistent_volume_framework_test.sh
src/tests/dynamic_reservation_framework_test.sh (line 30)
<https://reviews.apache.org/r/37168/#comment181637>
Thy do we need this? Comparing to persistent_volume_framework_test.sh
src/tests/examples_tests.cpp (line 36)
<https://reviews.apache.org/r/37168/#comment181636>
additional blank line.
- Joerg Schad
On Feb. 21, 2016, 2:07 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2016, 2:07 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide example for dynamic reservation features.
>
>
> Diffs
> -----
>
> src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e
> src/examples/dynamic_reservation_framework.cpp PRE-CREATION
> src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
> src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6
>
> Diff: https://reviews.apache.org/r/37168/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 37168: Add an example framework using dynamic
reservation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review122227
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37168]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 6, 2016, 11:25 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
>
> (Updated March 6, 2016, 11:25 a.m.)
>
>
> Review request for mesos, Adam B, Greg Mann, Joerg Schad, and Michael Park.
>
>
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide example for dynamic reservation features.
>
>
> Diffs
> -----
>
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/examples/dynamic_reservation_framework.cpp PRE-CREATION
> src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
> src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695
>
> Diff: https://reviews.apache.org/r/37168/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 37168: Add an example framework using dynamic
reservation.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
-----------------------------------------------------------
(Updated March 6, 2016, 7:25 p.m.)
Review request for mesos, Adam B, Greg Mann, Joerg Schad, and Michael Park.
Changes
-------
Address joerg84's comments.
Summary (updated)
-----------------
Add an example framework using dynamic reservation.
Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063
Repository: mesos
Description
-------
Provide example for dynamic reservation features.
Diffs (updated)
-----
src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
src/examples/dynamic_reservation_framework.cpp PRE-CREATION
src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695
Diff: https://reviews.apache.org/r/37168/diff/
Testing
-------
make
make check
Thanks,
Klaus Ma
Re: Review Request 37168: Added example for dynamic reservation
features.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review120074
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37168]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 21, 2016, 2:07 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2016, 2:07 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide example for dynamic reservation features.
>
>
> Diffs
> -----
>
> src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e
> src/examples/dynamic_reservation_framework.cpp PRE-CREATION
> src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
> src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6
>
> Diff: https://reviews.apache.org/r/37168/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 37168: Added example for dynamic reservation
features.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
-----------------------------------------------------------
(Updated Feb. 21, 2016, 10:07 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Update summary to add period
Summary (updated)
-----------------
Added example for dynamic reservation features.
Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063
Repository: mesos
Description
-------
Provide example for dynamic reservation features.
Diffs
-----
src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e
src/examples/dynamic_reservation_framework.cpp PRE-CREATION
src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6
Diff: https://reviews.apache.org/r/37168/diff/
Testing
-------
make
make check
Thanks,
Klaus Ma
Re: Review Request 37168: Add an example framework using dynamic
reservation.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
-----------------------------------------------------------
(Updated Feb. 21, 2016, 9:49 p.m.)
Review request for mesos and Michael Park.
Changes
-------
rebase & ping @mcypark :).
Summary (updated)
-----------------
Add an example framework using dynamic reservation.
Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063
Repository: mesos
Description
-------
Provide example for dynamic reservation features.
Diffs (updated)
-----
src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e
src/examples/dynamic_reservation_framework.cpp PRE-CREATION
src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
src/tests/examples_tests.cpp 9b8b30f3718aa0fa9d02a3aa344634f0c03e61e6
Diff: https://reviews.apache.org/r/37168/diff/
Testing
-------
make
make check
Thanks,
Klaus Ma
Re: Review Request 37168: MESOS-3063 (Add an example framework using
dynamic reservation)
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review114192
-----------------------------------------------------------
ping @mcypark :).
- Klaus Ma
On Dec. 13, 2015, 11:28 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2015, 11:28 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide example for dynamic reservation features.
>
>
> Diffs
> -----
>
> src/Makefile.am 9762f85
> src/examples/dynamic_reservation_framework.cpp PRE-CREATION
> src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
> src/tests/examples_tests.cpp 5211f54
>
> Diff: https://reviews.apache.org/r/37168/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 37168: MESOS-3063 (Add an example framework using
dynamic reservation)
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review110178
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37168]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 13, 2015, 3:28 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2015, 3:28 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide example for dynamic reservation features.
>
>
> Diffs
> -----
>
> src/Makefile.am 9762f85
> src/examples/dynamic_reservation_framework.cpp PRE-CREATION
> src/tests/dynamic_reservation_framework_test.sh PRE-CREATION
> src/tests/examples_tests.cpp 5211f54
>
> Diff: https://reviews.apache.org/r/37168/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>