You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/11/19 01:53:26 UTC

[GitHub] spark pull request #23054: [SPARK-26085][SQL] Key attribute of non-struct ty...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23054#discussion_r234476607
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
    @@ -459,7 +460,11 @@ class KeyValueGroupedDataset[K, V] private[sql](
           columns.map(_.withInputType(vExprEnc, dataAttributes).named)
         val keyColumn = if (!kExprEnc.isSerializedAsStruct) {
           assert(groupingAttributes.length == 1)
    -      groupingAttributes.head
    +      if (SQLConf.get.aliasNonStructGroupingKey) {
    --- End diff --
    
    we should do the lias when config is true...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org