'make *check' documentation Re: svn commit: r1683071 - /subversion/trunk/INSTALL

[Daniel Shahaf <d....@daniel.shahaf.name>]

danielsh@apache.org wrote on Tue, Jun 02, 2015 at 10:42:29 -0000:
> +++ subversion/trunk/INSTALL Tue Jun  2 10:42:29 2015
> @@ -590,7 +590,10 @@ II.   INSTALLATION
>            $ make
>            # make install
>  
> -      You can also run the full test suite by running 'make check'.
> +      You can also run the full test suite by running 'make check'.  Even
> +      in successful runs, some tests will report XFAIL; that is normal.
> +      Failed runs are indicated by FAIL or XPASS results, or a non-zero exit
> +      code from "make check".

Shouldn't we be saying something about running one or more of
    make svnserveautocheck
    make davautocheck
    make check FS_TYPE=bdb
    make check-swig-py
if those components are to be used?

I think the last one may be covered by the bindings README, but I'm not
sure about the others.  (Context: this is the documentation for users
building from a tarball.)

Re: 'make *check' documentation Re: svn commit: r1683071 - /subversion/trunk/INSTALL

[Branko Čibej <br...@wandisco.com>]

On 02.06.2015 12:50, Daniel Shahaf wrote:
> danielsh@apache.org wrote on Tue, Jun 02, 2015 at 10:42:29 -0000:
>> +++ subversion/trunk/INSTALL Tue Jun  2 10:42:29 2015
>> @@ -590,7 +590,10 @@ II.   INSTALLATION
>>            $ make
>>            # make install
>>  
>> -      You can also run the full test suite by running 'make check'.
>> +      You can also run the full test suite by running 'make check'.  Even
>> +      in successful runs, some tests will report XFAIL; that is normal.
>> +      Failed runs are indicated by FAIL or XPASS results, or a non-zero exit
>> +      code from "make check".
> Shouldn't we be saying something about running one or more of
>     make svnserveautocheck
>     make davautocheck
>     make check FS_TYPE=bdb
>     make check-swig-py
> if those components are to be used?
>
> I think the last one may be covered by the bindings README, but I'm not
> sure about the others.  (Context: this is the documentation for users
> building from a tarball.)

IMO, this sort of docco should be in subversin/tests/cmdline/README and
INSTALL should just point to that file.

-- Brane