You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Mathijs den Burger (JIRA)" <ta...@jakarta.apache.org> on 2006/05/22 17:08:29 UTC
[jira] Created: (TAPESTRY-958) Table column headers with a custom
render block cannot be sorted
Table column headers with a custom render block cannot be sorted
----------------------------------------------------------------
Key: TAPESTRY-958
URL: http://issues.apache.org/jira/browse/TAPESTRY-958
Project: Tapestry
Type: Bug
Components: Contrib
Versions: 4.0.2
Reporter: Mathijs den Burger
Priority: Minor
With contrib:Table, a custom Block can be used to render a table column header (in my case, I'd like to render an Image in the header instead of the column name). However, the link in the header to sort the column is not rendered anymore when a custom block is used for the column header. This makes the column effectively unsortable, which I would not expect to be desired behavior...
I guess this can simply be fixed in SimpleTableColumnComponent by rendering the supplied custom Block inside a copy of the "linkColumn" component, so clicking somewhere on content in the custom supplied block (in my case: an image) also sorts the column.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-958) Table column headers with a custom
render block cannot be sorted
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-958?page=all ]
Jesse Kuhnert updated TAPESTRY-958:
-----------------------------------
Fix Version/s: 4.1.2
> Table column headers with a custom render block cannot be sorted
> ----------------------------------------------------------------
>
> Key: TAPESTRY-958
> URL: http://issues.apache.org/jira/browse/TAPESTRY-958
> Project: Tapestry
> Issue Type: Bug
> Components: Contrib
> Affects Versions: 4.0.2
> Reporter: Mathijs den Burger
> Priority: Minor
> Fix For: 4.1.2
>
>
> With contrib:Table, a custom Block can be used to render a table column header (in my case, I'd like to render an Image in the header instead of the column name). However, the link in the header to sort the column is not rendered anymore when a custom block is used for the column header. This makes the column effectively unsortable, which I would not expect to be desired behavior...
> I guess this can simply be fixed in SimpleTableColumnComponent by rendering the supplied custom Block inside a copy of the "linkColumn" component, so clicking somewhere on content in the custom supplied block (in my case: an image) also sorts the column.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-958) Table column headers with a custom
render block cannot be sorted
Posted by "Mind Bridge (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-958?page=comments#action_12427737 ]
Mind Bridge commented on TAPESTRY-958:
--------------------------------------
I would also suggest to define the link yourself in the template and to tie the link to a method that does the following:
ITableSortingState sortingState = tableModel.getSortingState();
if (columnName.equals(sortingState.getSortColumn()))
sortingState.setSortColumn(columnName, !sortingState.getSortOrder());
else sortingState.setSortColumn(columnName, ITableSortingState.SORT_ASCENDING);
This will duplicate the functionality of the standard column implementation.
> Table column headers with a custom render block cannot be sorted
> ----------------------------------------------------------------
>
> Key: TAPESTRY-958
> URL: http://issues.apache.org/jira/browse/TAPESTRY-958
> Project: Tapestry
> Issue Type: Bug
> Components: Contrib
> Affects Versions: 4.0.2
> Reporter: Mathijs den Burger
> Priority: Minor
>
> With contrib:Table, a custom Block can be used to render a table column header (in my case, I'd like to render an Image in the header instead of the column name). However, the link in the header to sort the column is not rendered anymore when a custom block is used for the column header. This makes the column effectively unsortable, which I would not expect to be desired behavior...
> I guess this can simply be fixed in SimpleTableColumnComponent by rendering the supplied custom Block inside a copy of the "linkColumn" component, so clicking somewhere on content in the custom supplied block (in my case: an image) also sorts the column.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-958) Table column headers with a custom
render block cannot be sorted
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-958?page=comments#action_12427731 ]
Andreas Andreou commented on TAPESTRY-958:
------------------------------------------
Yes, but this wouldn't allow complete control of the table column header, would it?
Taking a look at the .java, .jwc, .html of SimpleTableColumnComponent
I would prefer to create my own ColumnSortLink and ColumnSortImage
components, and use those in my custom Blocks.
> Table column headers with a custom render block cannot be sorted
> ----------------------------------------------------------------
>
> Key: TAPESTRY-958
> URL: http://issues.apache.org/jira/browse/TAPESTRY-958
> Project: Tapestry
> Issue Type: Bug
> Components: Contrib
> Affects Versions: 4.0.2
> Reporter: Mathijs den Burger
> Priority: Minor
>
> With contrib:Table, a custom Block can be used to render a table column header (in my case, I'd like to render an Image in the header instead of the column name). However, the link in the header to sort the column is not rendered anymore when a custom block is used for the column header. This makes the column effectively unsortable, which I would not expect to be desired behavior...
> I guess this can simply be fixed in SimpleTableColumnComponent by rendering the supplied custom Block inside a copy of the "linkColumn" component, so clicking somewhere on content in the custom supplied block (in my case: an image) also sorts the column.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-958) Table column headers with a custom
render block cannot be sorted
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Andreou reassigned TAPESTRY-958:
----------------------------------------
Assignee: Andreas Andreou
> Table column headers with a custom render block cannot be sorted
> ----------------------------------------------------------------
>
> Key: TAPESTRY-958
> URL: https://issues.apache.org/jira/browse/TAPESTRY-958
> Project: Tapestry
> Issue Type: Bug
> Components: Contrib
> Affects Versions: 4.0.2
> Reporter: Mathijs den Burger
> Assigned To: Andreas Andreou
> Priority: Minor
> Fix For: 4.1.2
>
>
> With contrib:Table, a custom Block can be used to render a table column header (in my case, I'd like to render an Image in the header instead of the column name). However, the link in the header to sort the column is not rendered anymore when a custom block is used for the column header. This makes the column effectively unsortable, which I would not expect to be desired behavior...
> I guess this can simply be fixed in SimpleTableColumnComponent by rendering the supplied custom Block inside a copy of the "linkColumn" component, so clicking somewhere on content in the custom supplied block (in my case: an image) also sorts the column.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-958) Table column headers with a custom
render block cannot be sorted
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Andreou resolved TAPESTRY-958.
--------------------------------------
Resolution: Fixed
Use @contrib:ColumnSortLink and @contrib:ColumnSortImage
> Table column headers with a custom render block cannot be sorted
> ----------------------------------------------------------------
>
> Key: TAPESTRY-958
> URL: https://issues.apache.org/jira/browse/TAPESTRY-958
> Project: Tapestry
> Issue Type: Bug
> Components: Contrib
> Affects Versions: 4.0.2
> Reporter: Mathijs den Burger
> Assigned To: Andreas Andreou
> Priority: Minor
> Fix For: 4.1.2
>
>
> With contrib:Table, a custom Block can be used to render a table column header (in my case, I'd like to render an Image in the header instead of the column name). However, the link in the header to sort the column is not rendered anymore when a custom block is used for the column header. This makes the column effectively unsortable, which I would not expect to be desired behavior...
> I guess this can simply be fixed in SimpleTableColumnComponent by rendering the supplied custom Block inside a copy of the "linkColumn" component, so clicking somewhere on content in the custom supplied block (in my case: an image) also sorts the column.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-958) Table column headers with a custom
render block cannot be sorted
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-958?page=comments#action_12427826 ]
Andreas Andreou commented on TAPESTRY-958:
------------------------------------------
On the other hand, it might actually be useful for the contrib library to provide these two components...
Then one could do:
<table jwcid="contrib:Table" ...>
<span jwcid="idColumnHeader@Block">
Add html for the header... <a jwcid="@contrib:ColumnSortLink"><img jwcid="@contrib:ColumnSortImage"/></a>
</span>
</table>
So, i'm leaving this open - I think it's a nice idea & we can go ahead with this.
> Table column headers with a custom render block cannot be sorted
> ----------------------------------------------------------------
>
> Key: TAPESTRY-958
> URL: http://issues.apache.org/jira/browse/TAPESTRY-958
> Project: Tapestry
> Issue Type: Bug
> Components: Contrib
> Affects Versions: 4.0.2
> Reporter: Mathijs den Burger
> Priority: Minor
>
> With contrib:Table, a custom Block can be used to render a table column header (in my case, I'd like to render an Image in the header instead of the column name). However, the link in the header to sort the column is not rendered anymore when a custom block is used for the column header. This makes the column effectively unsortable, which I would not expect to be desired behavior...
> I guess this can simply be fixed in SimpleTableColumnComponent by rendering the supplied custom Block inside a copy of the "linkColumn" component, so clicking somewhere on content in the custom supplied block (in my case: an image) also sorts the column.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org