[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

[GitBox <gi...@apache.org>]

cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API
URL: https://github.com/apache/spark/pull/25206#issuecomment-513532914
 
 
   > but we do need to decide whether to require that both identifiers start with the same catalog
   
   A similar problem was already discussed before and the decision was: RENAME TABLE should only do rename, not things like moving databases. As a result, the `ExternalCatalog.renameTable` is defined as `def renameTable(db: String, oldName: String, newName: String): Unit`.
   
   We can also enforce it at the parser level: `ALTER TABLE multiPartName RENAME TO singlePartName`. We didn't do it before for backward compatibility reasons, it's a good chance to do it for DS v2 now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org