You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/05/31 23:43:37 UTC

[jira] Created: (HADOOP-6794) Move configuration and script files post split

Move configuration and script files post split
----------------------------------------------

                 Key: HADOOP-6794
                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
             Project: Hadoop Common
          Issue Type: Improvement
          Components: conf, scripts
            Reporter: Tom White
            Assignee: Tom White
            Priority: Blocker
             Fix For: 0.21.0




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

I've just committed this.

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

    Status: Patch Available  (was: Open)

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6794) Move configuration and script files post split

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874489#action_12874489 ] 

Vinod K V commented on HADOOP-6794:
-----------------------------------

The latest patches for the three projects look good, Tom. I could use HADOOP-6461 to successfully bring up single node clusters of both hdfs and mapreduce. I ran a simple mapreduce job too.

+1.

Thanks for taking this up!

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6794) Move configuration and script files post split

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877790#action_12877790 ] 

Hudson commented on HADOOP-6794:
--------------------------------

Integrated in Hadoop-Common-trunk #363 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/363/])
    HADOOP-6794. Move configuration and script files post split. Includes HDFS-1181, MAPREDUCE-1033.


> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

    Attachment: HADOOP-6794.patch

See https://issues.apache.org/jira/browse/MAPREDUCE-1033?focusedCommentId=12873810&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12873810

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6794) Move configuration and script files post split

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879098#action_12879098 ] 

Hudson commented on HADOOP-6794:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #310 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/310/])
    

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6794) Move configuration and script files post split

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873999#action_12873999 ] 

Vinod K V commented on HADOOP-6794:
-----------------------------------

The following need to be added to the patch.

conf/hadoop-policy.xml.template:
 - {{security.admin.operations.protocol.acl}} configuration property is not present in common-project but is present and needed in mapreduce.

conf/log4j.properties
 - Nine settings for 'Job Summary Appender' are present and needed in mapreduce project but are not there in common project.
 - Two settings for mapreduce task logs are present and needed in mapreduce project but are not there in common project.
    -- hadoop.tasklog.iscleanup=false
    -- log4j.appender.TLA.isCleanup=${hadoop.tasklog.iscleanup}
 - One more thing: copying this file over from mapreduce will not work because six settings for 'Security appender' are in common but not present in the mapreduce project's log4j.properties file.

May be we should also split both the above files per project. But that may be long term, will open a separate ticket if you agree.

Other issues
 - Minor: bin/rcc still refers to hadoop-core at one place.
 - when i run `ant binary` in hdfs bin directory isn't getting copied into the packaged binary, neither are the hdfs script files copied.
 - when i run `ant binary` in mapreduce, files aren't getting copied into the packaged bin directory

Verified the rest of the changes in all the three patches, they look good.

Still couldn't get the cluster up with different installation directories, will be trying in the meanwhile..

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

    Status: Patch Available  (was: Open)

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874624#action_12874624 ] 

Tom White commented on HADOOP-6794:
-----------------------------------

Thanks for the review, Vinod. I plan to commit these three patches soon.

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

    Attachment: HADOOP-6794.patch

A minor change to the patches which makes HADOOP_COMMON_HOME, HADOOP_HDFS_HOME, and HADOOP_MAPRED_HOME default to HADOOP_HOME if they are not set.

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

    Attachment: HADOOP-6794.patch

A minor change that loosens the jar glob pattern at the top-level from {{hadoop-common-*.jar}} to {{hadoop-*.jar}}. This change supports an installation where all the scripts, configuration and jars are in common directories, as produced by HADOOP-6342. I successfully ran a job on a pseudo-distributed cluster in this mode.

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

    Attachment: HADOOP-6794.patch

Updated to pick up webapps from the classpath. With this change (and HADOOP-6461) the web UIs work correctly.

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

    Status: Open  (was: Patch Available)

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6794) Move configuration and script files post split

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6794:
------------------------------

    Attachment: HADOOP-6794.patch

Vinod, many thanks for the thorough review. I've made fixes for all the errors you pointed out. Common's conf/log4j.properties is now a merged superset of the log4j.properties - I think we can split it out further later as needed.

I tried running with different installation directories, and successfully ran a job in pseudo-distributed mode. However, I did notice that the web UIs were not working, which I think will be fixed as a part of HADOOP-6461, although I'm still investigating that. 

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6794) Move configuration and script files post split

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877626#action_12877626 ] 

Hudson commented on HADOOP-6794:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #293 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/293/])
    HADOOP-6794. Move configuration and script files post split. Includes HDFS-1181, MAPREDUCE-1033.


> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6794) Move configuration and script files post split

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874449#action_12874449 ] 

Hadoop QA commented on HADOOP-6794:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12446104/HADOOP-6794.patch
  against trunk revision 950309.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/console

This message is automatically generated.

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch, HADOOP-6794.patch, HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6794) Move configuration and script files post split

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873818#action_12873818 ] 

Hadoop QA commented on HADOOP-6794:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12445968/HADOOP-6794.patch
  against trunk revision 949658.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/console

This message is automatically generated.

> Move configuration and script files post split
> ----------------------------------------------
>
>                 Key: HADOOP-6794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6794
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, scripts
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6794.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.