You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/20 23:05:35 UTC

[GitHub] codecov-io edited a comment on issue #3834: Unify move method in PinotFS

codecov-io edited a comment on issue #3834: Unify move method in PinotFS
URL: https://github.com/apache/incubator-pinot/pull/3834#issuecomment-463430666
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3834?src=pr&el=h1) Report
   > Merging [#3834](https://codecov.io/gh/apache/incubator-pinot/pull/3834?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/0d981ab6f4ebaee68d8ff47ac165f875ce7e78f3?src=pr&el=desc) will **decrease** coverage by `26.06%`.
   > The diff coverage is `6.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3834/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3834?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3834       +/-   ##
   =============================================
   - Coverage     67.32%   41.25%   -26.07%     
   =============================================
     Files          1029     1152      +123     
     Lines         50790    57743     +6953     
     Branches       7096     8010      +914     
   =============================================
   - Hits          34192    23822    -10370     
   - Misses        14258    31901    +17643     
   + Partials       2340     2020      -320
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3834?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/pinot/filesystem/PinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9QaW5vdEZTLmphdmE=) | `0% <ø> (-100%)` | `0 <0> (ø)` | |
   | [...java/org/apache/pinot/filesystem/AzurePinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtYXp1cmUtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9BenVyZVBpbm90RlMuamF2YQ==) | `0% <0%> (-11.71%)` | `0 <0> (-4)` | |
   | [...java/org/apache/pinot/filesystem/LocalPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9Mb2NhbFBpbm90RlMuamF2YQ==) | `0% <0%> (-87.7%)` | `0 <0> (ø)` | |
   | [.../core/realtime/PinotLLCRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90TExDUmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `44.42% <0%> (-28.61%)` | `0 <0> (ø)` | |
   | [...ava/org/apache/pinot/filesystem/HadoopPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtaGFkb29wLWZpbGVzeXN0ZW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L2ZpbGVzeXN0ZW0vSGFkb29wUGlub3RGUy5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `56.91% <75%> (-22.77%)` | `0 <0> (ø)` | |
   | [...inot/core/data/readers/GenericRowRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvR2VuZXJpY1Jvd1JlY29yZFJlYWRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [.../org/apache/pinot/common/http/MultiGetRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaHR0cC9NdWx0aUdldFJlcXVlc3QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...n/function/PercentileEstMVAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9QZXJjZW50aWxlRXN0TVZBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...che/pinot/common/restlet/resources/TablesList.java](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVzTGlzdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | ... and [648 more](https://codecov.io/gh/apache/incubator-pinot/pull/3834/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3834?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3834?src=pr&el=footer). Last update [0d981ab...5ff4667](https://codecov.io/gh/apache/incubator-pinot/pull/3834?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org